[MacPorts] #45107: upgrade Digikam to 4.3.0 (needs work)
#45107: upgrade Digikam to 4.3.0 (needs work) -------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: digikam -------------------------+-------------------------------- I'm attaching an updated Portfile for digikam, of which version 4.3.0 was released the past week. It should work fine when no digikam version is installed. I had the older version (4.0.0) installed (through my own portfile which is near identical to the one that was subsequently added to the main repository. This older port installed plugin header files (for libkgeomap) under ${prefix}/include and there appears to be an issue with the CMake files which cause it to pick up those headers. It should pick up the headers with the bundled libkgeomap *newer version* instead. The current, 4.0.0 Portfile has a few other oddities also signalled on the currently ongoing discussion on the ML, and that I tried to correct. I'm posting this diff in hope someone more knowledgeable about CMake in general and MacPorts "protected build environment" in general can look into the issue. I have not yet implemented a post-destroot script to prevent unwanted header files from being installed by removing them there, which seems to be the best approach. The Debian/Ubuntu package managers followed a similar approach: they don't bundle those files during the package generation process. -- Ticket URL: <https://trac.macports.org/ticket/45107> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Changes (by ryandesign@…): * cc: jan@… (removed) * cc: ryandesign@… (added) * owner: macports-tickets@… => jan@… Comment: This ticket supersedes #44666. If a previous install of the port causes build failure, and we cannot determine what to modify in the build to fix that, we can use: {{{ PortGroup conflicts_build 1.0 ... conflicts_build ${name} }}} -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Comment (by rjvbertin@…): Fine with me, I'll leave someone else to test that (though I can see what happens when I do `port -v destroot digikam` with my current 4.3.0 installed ... when not using my rig for other intensive stuff; this is not a small port). -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Comment (by bugports@…): The patch worked for me after uninstalling version 4.0 (Xcode 3.2.6 for Mac OS X 10.6), but ShowFoto is broken after the build. GUI quirk: If you turn off the menubar and click on the "albums" button on the left side, the editor is starting instead. -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Comment (by rjvbertin@…): Those are issues that should be reported on bugs.kde.org as they are not due to the portfile unlikely to be caused by the MacPorts patches. -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Comment (by caulier.gilles@…): Hi, I compile digiKam from git/master (current 4.5.0 implementation), and the dysfunction is not reproducible here. So your patch has broken something... Gilles Caulier -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#45107: upgrade Digikam to 4.3.0 (needs work) --------------------------+---------------------- Reporter: rjvbertin@… | Owner: jan@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: digikam | --------------------------+---------------------- Comment (by rjvbertin@…): Sorry, but no. From core/showfoto/CMakelists.txt: {{{ KDE4_ADD_EXECUTABLE(showfoto ${showfoto_SRCS}) # To fill plist XML file for OSX ##################################################### SET(MACOSX_BUNDLE_LONG_VERSION_STRING ${DIGIKAM_VERSION_STRING}) SET(MACOSX_BUNDLE_SHORT_VERSION_STRING ${DIGIKAM_VERSION_SHORT}) SET(MACOSX_BUNDLE_BUNDLE_VERSION ${DIGIKAM_VERSION_STRING}) CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/templates/Info.plist.cmake.in ${CMAKE_CURRENT_BINARY_DIR}/Info.plist) SET_TARGET_PROPERTIES(showfoto PROPERTIES MACOSX_BUNDLE_INFO_PLIST ${CMAKE_CURRENT_BINARY_DIR}/Info.plist) }}} and from that `${CMAKE_CURRENT_SOURCE_DIR}/../cmake/templates/Info.plist.cmake.in` : {{{ <key>CFBundleExecutable</key> <string>digiKam</string> <key>CFBundleGetInfoString</key> <string>digiKam is an advanced digital photo management application for Linux, Windows, and Mac-OSX</string> }}} I've had to launch a full rebuild of the port, so cannot yet affirm or infirm, but it would seem that the digikam 4.4.0 build system generates a showfoto appbundle with an Info.plist that sets the bundle executable to digiKam instead of to showfoto. NB: I'm not sure if OS X uses a case-sensitive algorithm to match the bundle executable string from the InfoDictionary to the file(s) it finds in Contents/MacOS, but it's not unlikely that using camelCase in the CFBundleExecutable and lowercase in the actual binary filename will lead to launch issues on a case-sensitive filesystem. -- Ticket URL: <https://trac.macports.org/ticket/45107#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts