[MacPorts] #35872: git-flow: update to use github PortGroup
#35872: git-flow: update to use github PortGroup --------------------------------------+------------------------------------- Reporter: jason-macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: git-flow --------------------------------------+------------------------------------- Few `Portfile` updates: * use `PortGroup github` * add `openmaintainer` (so I don't slow things down) * submodule update to single git command As a question, has anyone considered making `--recursive` a default option on the `git clone` to address `submodule` captures? -- Ticket URL: <https://trac.macports.org/ticket/35872> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35872: git-flow: update to use github PortGroup --------------------------------------+------------------------------------- Reporter: jason-macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: git-flow --------------------------------------+------------------------------------- Comment(by ryandesign@…): A couple comments: * You don't need to add "`universal_variant no`"; it's implied by "`supported_archs noarch`". * You can remove "`homepage http://github.com/nvie/gitflow`"; the github portgroup does that for you. * Using "`--recursive`" wouldn't be something the github portgroup would do for you since I assume that option is not specific to the github hosting service but is general to any server hosting git repositories; if anything, it would be an option we could add to MacPorts base—assuming the existing means of adding arguments to commands is insufficient for that purpose. -- Ticket URL: <https://trac.macports.org/ticket/35872#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35872: git-flow: update to use github PortGroup --------------------------------------+------------------------------------- Reporter: jason-macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: git-flow --------------------------------------+------------------------------------- Comment(by jason-macports@…): Suggestions 1 & 2 corrected and attachments replaced. -- Ticket URL: <https://trac.macports.org/ticket/35872#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35872: git-flow: update to use github PortGroup --------------------------------------+------------------------------------- Reporter: jason-macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: git-flow --------------------------------------+------------------------------------- Comment(by jason-macports@…): Regarding the git fetch, in `portfetch.tcl`, `git.*` does not have default argument elements, e.g. `svn.pre_args`, and it seems that `portfetch::gitfetch()` does not use the input `args`. It would seem that it would be necessary to add at least a `default git.clone_args ""` and modify `portfetch::gitfetch()`'s `cmdstring` to be something like: `set cmdstring "${git.cmd} clone ${git.clone_args} $options ...`. Since the `--recursive` option seems to be harmless if there are no submodules, perhaps it's easier to just `set options "-q --recursive"`? This has probably reached the level of a separate enhancement request, yes? Shall I put it in? -- Ticket URL: <https://trac.macports.org/ticket/35872#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35872: git-flow: update to use github PortGroup -------------------------------+--------------------------------- Reporter: jason-macports@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: git-flow | -------------------------------+--------------------------------- Changes (by cal@…): * status: new => closed * resolution: => fixed Comment: Replying to [comment:3 jason-macports@…]:
This has probably reached the level of a separate enhancement request, yes? Shall I put it in?
Yes, please. Commited in r97786. -- Ticket URL: <https://trac.macports.org/ticket/35872#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts