[MacPorts] #33575: stimfit
#33575: stimfit -----------------------------+---------------------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: -----------------------------+---------------------------------------------- It's in the Debian repositories, if that is relevant at all: http://packages.debian.org/sid/stimfit -- Ticket URL: <https://trac.macports.org/ticket/33575> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33575: stimfit -----------------------------+---------------------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: stimfit -----------------------------+---------------------------------------------- Changes (by macsforever2000@…): * version: 2.0.4 => * port: => stimfit Comment: Looks good but I have a few comments: 1. It is preferable if you allow the user to choose the python version by making variants for python26, python27, python31, etc. You can make python27 the default. See the inkscape port for an example. 1. Use {{{${applications_dir}}}} instead of hardcoding {{{/Applications/Macports}}} in post-destroot. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33575: stimfit -----------------------------+---------------------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: stimfit -----------------------------+---------------------------------------------- Comment(by christsc@…): Thanks for your review. Replying to [comment:1 macsforever2000@…]:
Looks good but I have a few comments: 1. It is preferable if you allow the user to choose the python version by making variants for python26, python27, python31, etc. You can make python27 the default. See the inkscape port for an example.
There's no python26 port for wxpython-devel yet. I've started a ticket ([http://trac.macports.org/ticket/33590 #33590]). Pending its acceptance, the python26 variant is commented out.
2. Use {{{${applications_dir}}}} instead of hardcoding {{{/Applications/Macports}}} in post-destroot.
Done. The app bundle now gets installed to {{{${destroot}${applications_dir}}}} so that uninstall can clean up properly. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33575: NEW: stimfit -----------------------------+---------------------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: stimfit -----------------------------+---------------------------------------------- -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: stimfit | -------------------------+-------------------------------- Comment (by christsc@…): Stimfit now uses wxWidgets30 and py27-wxpython30: https://stimfit.googlecode.com/git/macosx/macports/science/stimfit/Portfile Let me know what remains to be done to get this included into MacPorts. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: stimfit | -------------------------+-------------------------------- Comment (by ciserlohn@…): Before including into MacPorts some questions and remarks: {{{ license GPL }}} - Can you indicate the version (e.g. GPL-2)? {{{ supported_archs x86_64 }}} - really no i386 and PowerPC? The debian repository you mentioned provides packages for both. {{{ if {![variant_isset python27]} { default_variants +python27 } }}} - The {{{default_variants}}} should not be inside a if block. This idiom makes only sense if you have more than on python variant and would like to make one the default if none had explicitly chosen by the user. {{{ variant python27 description {Build with Python shell. Only 2.7 is supported.} }}} - {{{ Only 2.7 is supported}}} should not be in the variant description but moved to a comment. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: stimfit | -------------------------+-------------------------------- Comment (by christsc@…): Thanks for your review. Replying to [comment:17 ciserlohn@…]:
Before including into MacPorts some questions and remarks:
{{{ license GPL }}} - Can you indicate the version (e.g. GPL-2)?
Fixed in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3 r5ed64d7830c3].
{{{ supported_archs x86_64 }}} - really no i386 and PowerPC? The debian repository you mentioned provides packages for both.
Added i386 in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3 r5ed64d7830c3]. File I/O depends on endianness //and// OS; including ppc would require some thorough testing.
{{{ if {![variant_isset python27]} { default_variants +python27 } }}} - The {{{default_variants}}} should not be inside a if block. This idiom makes only sense if you have more than on python variant and would like to make one the default if none had explicitly chosen by the user.
Commented out in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3 r5ed64d7830c3], pending availability of wxPython for Python 3.x.
{{{ variant python27 description {Build with Python shell. Only 2.7 is supported.} }}} - {{{ Only 2.7 is supported}}} should not be in the variant description but moved to a comment.
Fixed in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3 r5ed64d7830c3]. Some additional fixes to address relevant issues from [https://trac.macports.org/ticket/37471#comment:18 Ticket 37471#comment18] were added in [https://code.google.com/p/stimfit/source/detail?r=609ada02fd6a r609ada02fd6a] and [https://code.google.com/p/stimfit/source/detail?r=45f538cbfddc r45f538cbfddc]. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:20> MacPorts <http://www.macports.org/> Ports system for OS X
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: stimfit | -------------------------+-------------------------------- Comment (by ciserlohn@…): Replying to [comment:20 christsc@…]:
Thanks for your review.
Replying to [comment:17 ciserlohn@…]:
Before including into MacPorts some questions and remarks:
{{{ license GPL }}} - Can you indicate the version (e.g. GPL-2)?
Fixed in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3 r5ed64d7830c3]. (...)
Some additional fixes to address relevant issues from [https://trac.macports.org/ticket/37471#comment:18 Ticket 37471#comment18] were added in [https://code.google.com/p/stimfit/source/detail?r=609ada02fd6a r609ada02fd6a] and [https://code.google.com/p/stimfit/source/detail?r=45f538cbfddc r45f538cbfddc].
Probably [comment:22:ticket:37471 this] is also an issue here (though I haven't tested it). -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:21> MacPorts <http://www.macports.org/> Ports system for OS X
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: stimfit | -------------------------+-------------------------------- Comment (by christsc@…): Replying to [comment:21 ciserlohn@…]:
[...]
Probably [comment:22:ticket:37471 this] is also an issue here (though I haven't tested it).
Fixed in [https://code.google.com/p/stimfit/source/detail?r=948c6eac5c8a r948c6eac5c8a] -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:22> MacPorts <http://www.macports.org/> Ports system for OS X
#33575: NEW: stimfit -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: stimfit | -------------------------+-------------------------------- Changes (by ciserlohn@…): * status: new => closed * resolution: => fixed Comment: r107508 -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:23> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts