[MacPorts] #37034: plplot: use cmake portgroup
#37034: plplot: use cmake portgroup --------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: plplot --------------------------+----------------------- The plplot portfile could probably be simplified by using the cmake portgroup. -- Ticket URL: <https://trac.macports.org/ticket/37034> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: plplot | ---------------------------+----------------------- Changes (by takeshi@…): * status: new => closed * resolution: => fixed Comment: Committed in r99949. -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: plplot | ---------------------------+----------------------- Comment (by ryandesign@…): There were still a couple problems. The cmake build dependency got removed; you probably received a [https://build.macports.org/builders/buildports-lion-x86_64/builds/6054 buildbot failure] notification about that. Fixed in r99952 by appending to, instead of overwriting, the portgroup's dependencies. There was still some code setting the variables cflags and cxxflags, but those variables were no longer used so I removed this code in r99953. The port still sets CMAKE_OSX_ARCHITECTURES manually, but the cmake portgroup does that for you. In fact it looks like in some cases (when the g95 variant is set and the universal variant is not set) the port wants CMAKE_OSX_ARCHITECTURES not to be set at all? If that's truly required, then I'm not sure if the cmake portgroup accommodates that need. Perhaps we can explore this further to find out why the port is doing this. -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: plplot | ---------------------------+----------------------- Changes (by ryandesign@…): * status: closed => reopened * resolution: fixed => -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: plplot | ---------------------------+----------------------- Comment (by takeshi@…): The problem is that gfortran-mp-4.x fails with -arch. I reverted to r99948 in r99965. It would be nice if PortGroup cmake had a feature to remove -arch when a fortran compiler is used. -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: plplot | ---------------------------+----------------------- Comment (by jmr@…): Does setting CMAKE_OSX_ARCHITECTURES cause cmake to pass -arch flags to every compiler used? Is that correct behaviour on cmake's part? -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37034: plplot: use cmake portgroup ---------------------------+----------------------- Reporter: ryandesign@… | Owner: takeshi@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: plplot | ---------------------------+----------------------- Comment (by takeshi@…): See also #37732. -- Ticket URL: <https://trac.macports.org/ticket/37034#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts