[MacPorts] #40742: py-PyQGLViewer @0.11 submission
#40742: py-PyQGLViewer @0.11 submission ---------------------------------+-------------------------------- Reporter: christophe.pradal@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Keywords: python, graphics | Port: ---------------------------------+-------------------------------- Tested on Mac 10.7.3. This port has a dependency on libPyQGLViewer. -- Ticket URL: <https://trac.macports.org/ticket/40742> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------------- Reporter: christophe.pradal@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: python, graphics Port: | ----------------------------------+-------------------------------- Comment (by christophe.pradal@…): libPyQGLViewer is a new port (#40741) -- Ticket URL: <https://trac.macports.org/ticket/40742#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------------- Reporter: christophe.pradal@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------------- Changes (by ryandesign@…): * keywords: python, graphics => * port: => py-PyQGLViewer Comment: Thanks. Some observations: * Since you are not a committer, the maintainers line must list your complete email address in our obfuscated host:user format. * "eq" should be used for string comparisons instead of "!=". * configure.pre_args is meant only for specifying the prefix; other arguments should go in configure.args. * "-I /opt/X11/include" should not be specified; MacPorts ports shall not use XQuartz or other non-MacPorts X11 implementations. If this port needs something from X11, it should declare a dependency on the appropriate xorg port. -- Ticket URL: <https://trac.macports.org/ticket/40742#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------------- Reporter: christophe.pradal@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------------- Comment (by christophe.pradal@…): Replying to [comment:2 ryandesign@…]: Thanks a lot for the very fast review. I have fixed the errors in the file Portfile.2
Thanks. Some observations: * Since you are not a committer, the maintainers line must list your complete email address in our obfuscated host:user format. Done: Change pradal into inria.fr:christophe.pradal
* "eq" should be used for string comparisons instead of "!=". Done. Change != into ne
* configure.pre_args is meant only for specifying the prefix; other arguments should go in configure.args. Done. To remove the --prefix in the configure, I let the configure.pre_args empty. Other args are defined in configure.args
* "-I /opt/X11/include" should not be specified; MacPorts ports shall not use XQuartz or other non-MacPorts X11 implementations. If this port needs something from X11, it should declare a dependency on the appropriate xorg port. Fixed. X11 is only needed with qt4-x11 and is not used currently.
-- Ticket URL: <https://trac.macports.org/ticket/40742#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------- Reporter: christophe.pradal@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: Assuming it builds, I'll commit this with some changes, including: * removed unnecessary distname line which made this an undesirable [PortfileRecipes#unversioned-distfiles unversioned distfile] * removed unnecessary "python.default_version 27" line (that's the default) * used ${python.bin} in configure.cmd instead of recreating its value * adjusted spacing to conform to modeline (indents at multiples of 4 spaces) * adjusted livecheck, though it doesn't work; fixing it can be grouped into #40790 -- Ticket URL: <https://trac.macports.org/ticket/40742#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------- Reporter: christophe.pradal@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: fixed | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: * Correction: distname line was still needed, but needed the version number added. * Fixed universal build by clearing configure.universal_args. * Fixed to actually do the building during the build phase instead of the destroot phase by fixing build.target. Committed in r112343. -- Ticket URL: <https://trac.macports.org/ticket/40742#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------- Reporter: christophe.pradal@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: fixed | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------- Comment (by ryandesign@…): It failed to build on the buildbots because GL.h wasn't found. Added mesa dependency in r112348. Since it didn't appear to link with the GL library, I just made it a build dependency. -- Ticket URL: <https://trac.macports.org/ticket/40742#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts