[MacPorts] #39532: pianobar: update to 2013.05.19
#39532: pianobar: update to 2013.05.19 --------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: pianobar --------------------------+-------------------------------------- {{{ $ port livecheck pianobar pianobar seems to have been updated (port version: 2012.12.01, new version: 2013.05.19) }}} -- Ticket URL: <https://trac.macports.org/ticket/39532> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: pianobar | ---------------------------+-------------------------------------- Comment (by ryandesign@…): {{{ $ port livecheck pianobar pianobar seems to have been updated (port version: 2012.12.01, new version: 2013.09.15) }}} -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Changes (by ryandesign@…): * cc: brian.andrew@… (added) * keywords: => haspatch Comment: Duplicate #40921 has a patch, but I'm worried about all the things it removes. I have a feeling some of it (like UsingTheRightCompiler and `-arch` flags and adding a universal variant and preventing upgrade errors) is still needed. -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Comment (by brian.andrew@…): You were right to be cautious. After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default. Anyway, here's a much milder patch that doesn't make as many sweeping changes, but still works. I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-) -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Comment (by ryandesign@…): Replying to [comment:3 brian.andrew@…]:
After some more testing it does turn out that my changes completely removed the ability to generate a universal port. I'm not sure why to be honest, I thought that was available by default.
It is—assuming the port uses an autoconf-compatible configure script. pianobar doesn't (c.f. `use_configure no`).
I guess I should just trust that if something is in a Portfile, it's probably there for a reason ;-)
Or use `svn blame` and `svn log` to determine why something is in a Portfile. -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Comment (by aronnax@…): The patch worked for me. -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Committed in r112643, though I see now that the source code is still available on the web site like it was before, and it's bz2 compressed, so I'm not sure why we switched to downloading from github which is gz compressed and thus larger. -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#39532: pianobar: update to 2013.09.15 ---------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: aguynamedryan+pianobar@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: pianobar | ---------------------------+-------------------------------------- Comment (by brian.andrew@…): I thought it made the port cleaner and given that even the website indicates that github is the place for up-to-date source/info it made sense to me to switch. -- Ticket URL: <https://trac.macports.org/ticket/39532#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts