[MacPorts] #34680: port atlas - remove ui_warn command from top level, add maintainer
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- atlas has an ''ui_warn'' [http://trac.macports.org/browser/trunk/dports/math/atlas/Portfile#L245 at portfile root level], this leads to the warning being printed whenever the portfile is read and parsed, like dependency checking for atlas' dependents or even a simple ''port lint atlas''. Please move into a more appropriate block, ''post-configure'' seems a good candidate. At the same time I suggest ''vince'' is marked as maintainer since most commits in last 18 months are his. -- Ticket URL: <https://trac.macports.org/ticket/34680> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- Description changed by and.damore@…: Old description:
atlas has an ''ui_warn'' [http://trac.macports.org/browser/trunk/dports/math/atlas/Portfile#L245 at portfile root level], this leads to the warning being printed whenever the portfile is read and parsed, like dependency checking for atlas' dependents or even a simple ''port lint atlas''.
Please move into a more appropriate block, ''post-configure'' seems a good candidate.
At the same time I suggest ''vince'' is marked as maintainer since most commits in last 18 months are his.
New description: atlas has an ''ui_warn'' at portfile root level [http://trac.macports.org/browser/trunk/dports/math/atlas/Portfile#L245 at line 245], this leads to the warning being printed whenever the portfile is read and parsed, like dependency checking for atlas' dependents or even a simple ''port lint atlas''. Please move into a more appropriate block, ''post-configure'' seems a good candidate. At the same time I suggest ''vince'' is marked as maintainer since most commits in last 18 months are his. -- -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- Comment(by vince@…): Should be fixed in r93768. I have no set myself maintainer, I think it must follow a collegial decision. BTW, I’m unable to contact James. His direct mail bounces, and I suspect the @macports.org does too, even if we don’t get any error message. -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- Comment(by vince@…): PS: I have moved the message in the "pre-fetch" phase, because I want the user to be warned early of this limitation (so that he may abort and opt for clang, for example). -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- Comment(by vince@…): I had made a typo 'pre-fecth' instead of pre-fetch. Corrected in r93769. -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer -------------------------------------+-------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: atlas -------------------------------------+-------------------------------------- Comment(by and.damore@…): Replying to [comment:2 vince@…]:
Should be fixed in r93768.
You should have waited before committing the patch. I've edited commit message to reference this ticket and #25662. Replying to [comment:2 vince@…]:
I have no set myself maintainer, I think it must follow a collegial decision.
No, you just need to be willing to maintain the package and follow the [http://guide.macports.org/#project.update-policies.abandonment abandonment policy]. Replying to [comment:2 vince@…]:
BTW, I’m unable to contact James. His direct mail bounces, and I suspect the @macports.org does too, even if we don’t get any error message.
I'm trying to contact him as well, if the email bounces I suggest you just take maintainership, there's no point in having a maintainer if he's not getting messages. Since this ticket is about editing maintainer I suggest to keep it open and update it later. -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer --------------------------------------+------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: Port: atlas | --------------------------------------+------------------------------------- Changes (by and.damore@…): * status: new => closed * resolution: => fixed Comment: Added vince as maintainer in r93931, maintainer timeout. Ticket closed. -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer --------------------------------------+------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: Port: atlas | --------------------------------------+------------------------------------- Comment(by jameskyle@…): @Vince More than happy to pass the maintainership to you. As has been noticed, my attention has been elsewhere for a while now. -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#34680: port atlas - remove ui_warn command from top level, add maintainer --------------------------------------+------------------------------------- Reporter: and.damore@… | Owner: jameskyle@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: Port: atlas | --------------------------------------+------------------------------------- Comment(by vince@…): @James Nice to hear from you James. Ok, I’ll take over then. Have fun! -- Ticket URL: <https://trac.macports.org/ticket/34680#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts