[MacPorts] #48588: Patch to fix trac: 41984
#48588: Patch to fix trac: 41984 ----------------------+-------------------------------- Reporter: wdc@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: gtksourceview2 ----------------------+-------------------------------- This new port file swaps me in as maintainer, and fixes the defect reported in Trac 41984. A previous patch file, patch-gtksourceview_gtksourceview-i18n.c.diff is eliminated. A different MacOS gtk2 integration is followed. gtk-osx-application-gtk2 is used instead of ige-mac-integration. This is necessary when both gtk2 and gtk3 ports are installed. Recognizing that gtk integration is a moving target, this new integration is more in harmony with upstream. (This is my first time taking over a port, and I may be imperfectly understanding the instructions. I hope that fixing the bug and taking over the port in the same ticket is ok.) -- Ticket URL: <https://trac.macports.org/ticket/48588> MacPorts <https://www.macports.org/> Ports system for OS X
#48588: Patch to fix trac: 41984 -----------------------------+-------------------------------- Reporter: wdc@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: duplicate | Keywords: haspatch Port: gtksourceview2 | -----------------------------+-------------------------------- Changes (by ionic@…): * status: new => closed * resolution: => duplicate Comment: Thanks. Please don't open duplicate tickets, instead, attach your patches to the other still open ticket and tell us what to apply exactly. Note that your `Portfile` patch mixes functional changes (e.g., the dependency updates etc.) and non-functional changes (maintainer change.) Now that the maintainer change is obsolete, your patch won't apply cleanly. Thus, we prefer minimal patches and if needed multiple of them so one patch basically is one semantic entity. -- Ticket URL: <https://trac.macports.org/ticket/48588#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48588: Patch to fix trac: 41984 -----------------------------+-------------------------------- Reporter: wdc@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: duplicate | Keywords: haspatch Port: gtksourceview2 | -----------------------------+-------------------------------- Description changed by ionic@…: Old description:
This new port file swaps me in as maintainer, and fixes the defect reported in Trac 41984.
A previous patch file, patch-gtksourceview_gtksourceview-i18n.c.diff is eliminated.
A different MacOS gtk2 integration is followed. gtk-osx-application-gtk2 is used instead of ige-mac-integration. This is necessary when both gtk2 and gtk3 ports are installed. Recognizing that gtk integration is a moving target, this new integration is more in harmony with upstream.
(This is my first time taking over a port, and I may be imperfectly understanding the instructions. I hope that fixing the bug and taking over the port in the same ticket is ok.)
New description: This new port file swaps me in as maintainer, and fixes the defect reported in Trac #41984. A previous patch file, patch-gtksourceview_gtksourceview-i18n.c.diff is eliminated. A different MacOS gtk2 integration is followed. gtk-osx-application-gtk2 is used instead of ige-mac-integration. This is necessary when both gtk2 and gtk3 ports are installed. Recognizing that gtk integration is a moving target, this new integration is more in harmony with upstream. (This is my first time taking over a port, and I may be imperfectly understanding the instructions. I hope that fixing the bug and taking over the port in the same ticket is ok.) -- -- Ticket URL: <https://trac.macports.org/ticket/48588#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts