[MacPorts] #28998: snappy @1.0.1 - New Port
#28998: snappy @1.0.1 - New Port ---------------------------------+------------------------------------------ Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: snappy ---------------------------------+------------------------------------------ Google has released their new library for compression/decompression. {{{ Port snappy contains: /opt/local/include/snappy-sinksource.h /opt/local/include/snappy-stubs-public.h /opt/local/include/snappy.h /opt/local/lib/libsnappy.1.dylib /opt/local/lib/libsnappy.a /opt/local/lib/libsnappy.dylib /opt/local/lib/libsnappy.la /opt/local/share/doc/snappy/ChangeLog /opt/local/share/doc/snappy/COPYING /opt/local/share/doc/snappy/INSTALL /opt/local/share/doc/snappy/NEWS /opt/local/share/doc/snappy/README }}} -- Ticket URL: <https://trac.macports.org/ticket/28998> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28998: snappy @1.0.1 - New Port ---------------------------------+------------------------------------------ Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: snappy ---------------------------------+------------------------------------------ Comment(by blb@…): A couple of initial observations: * {{{port lint}}} would like a '''platforms''' key (usually just {{{platforms darwin}}}) * it also wants an Id line, which you have but not in subversion's exact format; I usually just start with {{{# $Id$}}} in a new Portfile * Looks like this links against both liblzo2 and libz when available from MacPorts (according to an {{{otool -L}}} here); should those be listed as dependencies or is there a way to disable such linking? -- Ticket URL: <https://trac.macports.org/ticket/28998#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28998: snappy @1.0.1 - New Port ---------------------------------+------------------------------------------ Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: snappy ---------------------------------+------------------------------------------ Comment(by sepp@…): Thanks for the hints. I'll remember those for future Portfiles. I'll attach a new Portfile which should be fine now. -- Ticket URL: <https://trac.macports.org/ticket/28998#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28998: snappy @1.0.1 - New Port ----------------------------------+----------------------------------------- Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: snappy | ----------------------------------+----------------------------------------- Changes (by blb@…): * status: new => closed * resolution: => fixed Comment: Added in r77558, thanks. -- Ticket URL: <https://trac.macports.org/ticket/28998#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28998: snappy @1.0.1 - New Port ----------------------------------+----------------------------------------- Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: snappy | ----------------------------------+----------------------------------------- Changes (by ryandesign@…): * cc: blb@…, ryandesign@… (added) Comment: I've made some changes, which I would have liked to see included in the initial commit: * r77604: fixed whitespace to use spaces not tabs; added modeline; reordered some lines * r77605: simplified `master_sites` to just "`googlecode`" * r77606: removed unnecessary "`configure.args --prefix=${prefix}`"; MacPorts already puts `--prefix=${prefix}` in `configure.pre_args` for you * r77607: fixed typo in description * r77608: fixed license (1.0.1 is under the Apache 2.0 license; looks like future versions will be under the BSD license) -- Ticket URL: <https://trac.macports.org/ticket/28998#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28998: snappy @1.0.1 - New Port ----------------------------------+----------------------------------------- Reporter: sepp@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: snappy | ----------------------------------+----------------------------------------- Comment(by blb@…): Replying to [comment:4 ryandesign@…]:
I've made some changes, which I would have liked to see included in the initial commit:
* r77604: fixed whitespace to use spaces not tabs; added modeline; reordered some lines
Does this mean MacPorts now has a particular whitespace requirement? -- Ticket URL: <https://trac.macports.org/ticket/28998#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts