[MacPorts] #37276: Kinect support in OpenCV: openni-devel (submission), openni-devel-sensorkinect (submission), opencv (enhancement), openni (enhancement)
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: Kinect OpenCV OpenNI | Port: openni-devel openni- SensorKinect | devel-sensorkinect opencv openni -------------------------------------+------------------------------------- I have a set of submissions and enhancements that bring Kinect support to OpenCV. The submissions are: (1) openni-devel - the unstable branch of OpenNI (2) openni-devel-sensorkinect - the SensorKinect module for the unstable branch of OpenNI. The enhancements are to: (1) opencv - adding a variant, +openni-devel-sensorkinect, and a modified patch file, patch-cmake-OpenCVFindOpenNI.cmake.diff. These are for compilation against openni-devel-sensorkinect. (2) openni - adding a conflict with openni-devel because they would install conflicting dylibs. -- Ticket URL: <https://trac.macports.org/ticket/37276> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Changes (by jmr@…): * cc: stromnov@…, ryandesign@… (added) Comment: Adding opencv and openni maintainers to Cc. (Please remember to Cc maintainers when you create a ticket). -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by ryandesign@…): Regarding [attachment:Portfile.2 openni-devel-sensorkinect], the -devel suffix should go at the end (openni-sensorkinect-devel). Is there a reason why we cannot offer a stable version of this port? The `conflicts` keyword takes bare port names, not dependency specifiers, so it should be "`conflicts openni`", etc. Regarding the [attachment:Portfile-rrdtool.diff opencv patch], we don't typically use the word "devel" in variant names; we don't typically depend on -devel ports, though we can in cases like these where no non-devel port exists. Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request? You've also marked the tbb variant as conflicting with the universal variant. We can do that; I assume you've done this because tbb does not have a universal variant. It would be better to fix the tbb port; see #35990. Note that "rrdtool" is the name of a port. So the filename "Portfile- rrdtool.diff" shown in the guide was meant to be taken as an example in the hypothetical case where you are submitting a patch for the rrdtool port. -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by josephhowse@…): Thanks for the feedback. Here is some additional information that might address some of your comments. I'm happy to follow whatever naming convention is appropriate for the ports and variant. SensorKinect depends on unstable versions of OpenNI (1.5.4.0, 1.5.2.7, 1.4.0.2, etc.).
Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request?
we don't typically depend on -devel ports
An +openni variant was already added to opencv in a recent update. The difference between +openni_devel_sensorkinect (my submission) and the existing +openni variant is that +openni_devel_sensorkinect also supports Kinect via SensorKinect. Due to SensorKinect's dependency on an unstable OpenNI version, +openni_devel_sensorkinect depends on openni-devel, whereas +openni depends on (stable) openni.
The conflicts keyword takes bare port names, not dependency specifiers, so it should be "conflicts openni", etc.
Do you mean that "conflicts port:openni" should be "conflicts openni" (in the openni-devel Portfile)? Or is there some problem with the use of "conflicts" in "variant openni_devel_sensorkinect conflicts openni" (in the opencv patch)?
It would be better to fix the tbb port; see #35990.
If the tbb port is being fixed, then, yes, the proposed change to the opencv +tbb variant can be dropped. -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by egall@…): See also issue #37320 for more on updating tbb to fix the problems with OpenCV's +tbb and +universal variants -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by ryandesign@…): Replying to [comment:4 josephhowse@…]:
Note that we had an existing request to add an openni variant to the opencv port in #35512. Does this patch satisfy that request? An +openni variant was already added to opencv in a recent update.
Oh! Then I'll close that ticket.
The conflicts keyword takes bare port names, not dependency specifiers, so it should be "conflicts openni", etc.
Do you mean that "conflicts port:openni" should be "conflicts openni" (in the openni-devel Portfile)?
Yes, this is what I meant. -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by josephhowse@…): I've made the following changes, uploaded as the contents of graphics.zip: 1. openni-devel-sensorkinect renamed to openni-sensorkinect 2. opencv +openni_devel_sensorkinect renamed to opencv +openni_sensorkinect 3. dropped the modifications to opencv +tbb Also, the naming scheme of diff files is corrected. To reduce clutter, could an admin please delete the other attachments (all except graphics.zip)? Then, I'll re-upload individual files in the latest versions. Since some files are being renamed, it's not convenient to simply replace attachments. -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by josephhowse@…): If anyone has the chance to review this submission soon, that would be great. I am writing an OpenCV book for Packt Publishing and I would like to instruct Mac users to install the opencv +sensorkinect variant from MacPorts. When reviewing the submission, please see my previous comment about which attachments are still current. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Comment (by egall@…): The update of OpenCV to 2.4.6 with r107771 could have been a good time to add these variants... -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#37276: Kinect support in OpenCV: openni-devel (submission), openni-devel- sensorkinect (submission), opencv (enhancement), openni (enhancement) -------------------------------------+------------------------------------- Reporter: josephhowse@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: wontfix | Keywords: Kinect OpenCV OpenNI Port: openni-devel openni- | SensorKinect devel-sensorkinect opencv openni | -------------------------------------+------------------------------------- Changes (by mf2k@…): * status: new => closed * resolution: => wontfix Comment: This ticket has too many separate issues and is outdated. Please file separate tickets with updated portfiles for each individual submission and enhancement if you are still interested in this. -- Ticket URL: <https://trac.macports.org/ticket/37276#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts