#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: mplayer2 --------------------------------------+------------------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => cal@… -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by samuel.bateman@…): Replying to [comment:2 cal@…]:

I cannot reproduce this. What version of OS X are you using?

I am using a Mac Pro with OS X 10.6.8. My Xcode version is 3.2.6. I have also attached the output from "port installed", in case it matters. Thanks for looking into this. -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by sasoph@…): 10.5.8 PPC, Xcode 3.1.4 mplayer2 with the patch, gives an error: {{{ /usr/bin/gcc-4.0 -MD -MP -Wundef -Wstrict-prototypes -Wmissing- prototypes -Wdisabled-optimization -Wno-pointer-sign -std=gnu99 -O2 -arch ppc -maltivec -mabi=altivec -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -falign-loops=16 -shared-libgcc -mdynamic-no-pic -I. -I/opt/local/include -I/opt/local/include/freetype2 -O2 -arch ppc -Wno- pointer-sign -I/opt/local/include -I/opt/local/include/freetype2 -I/usr/X11/include -I/opt/local/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE -I/opt/local/include -I/opt/local/include/fribidi -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/libdvdread -c -o libvo/vo_corevideo.o libvo/vo_corevideo.m In file included from /opt/local/include/X11/Xlib.h:44, from libvo/gl_common.h:41, from libvo/vo_corevideo.m:40: /opt/local/include/X11/X.h:103: error: conflicting types for 'Cursor' /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QuickdrawTypes.h:269: error: previous declaration of 'Cursor' was here make: *** [libvo/vo_corevideo.o] Error 1 }}} -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by cal@…): My bad, please try again with the updated patch `mplayer2-vo_corevideo-x11 -naming-conflict.2.patch`. -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by samuel.bateman@…): Even with the second patch which doesn't include "x11_common.h", there is still a naming error because of the include "GL/glx.h". Maybe support for X11 and/or GLX should simply be disabled in the configure flags. X11 and Carbon/Quartz are sort of incompatible anyway. I've attached a patch for the Portfile with "--disable-x11" and "--disable-xv", which I was able to successfully get to compile on my system. -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by cal@…): sasoph, it seems unlikely that disabling x11 would cause problems with undeclared Cocoa data structures. Please clean mplayer2 and re-try and attach your main.log if it still fails. Samuel, the patch works fine for me on Lion, but that doesn't tell anything, because it worked fine for me before disabling x11, too. I'll wait for sasoph's feedback if you don't mind. Also, disabling x11 probably means a number of dependencies can be dropped from the Portfile. I'll need more time to look into what can be removed (unless you want to?). -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by cal@…): I don't know why this fails for you… `NSWindowDelegate` is defined in `/System/Library/Frameworks/AppKit.framework/Versions/C/Headers/NSWindow.h`, which should be included from `/System/Library/Frameworks/AppKit.framework/Versions/C/Headers/AppKit.h`, which should be included from `/System/Library/Frameworks/Cocoa.framework/Versions/A/Headers/Cocoa.h`, which is included from `cocoa_common.m` in line 20. (NB: I checked this in the 10.6 SDK on Lion, not against the versions shipped with Lion). Are you sure your Xcode installation is complete? Samuel, I'm attaching a patch against the Portfile that should completely disable X11 and also remove the unnecessary dependencies. Can you test whether this still builds for you? -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:13> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by samuel.bateman@…): cal, your patch works for me. mplayer2 compiles fine after applying it. sasoph, a quick Google search reveals this (https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/NSWin...): "Available in OS X v10.6 and later." But you are using 10.5. I've attached a patch based on the workaround found here (http://forum.jogamp.org/Mac-OS-X-10-5-compile-error-td858747.html). sasoph, could you try this? First, apply the mplayer2-disable-x11.patch, then apply the mplayer2-appkit-fix-for-10.5.patch, then try building again. -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:15> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' --------------------------------------+------------------------------------- Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: mplayer2 --------------------------------------+------------------------------------- Comment(by sasoph@…): Since cal has committed -disable-x11.patch, I assumed that I only need use -appkit-fix-for-10.5.patch. If so, there are more errors: {{{ libvo/cocoa_common.m: In function 'vo_cocoa_init': libvo/cocoa_common.m:146: error: 'NSApplicationActivationPolicyRegular' undeclared (first use in this function) libvo/cocoa_common.m:146: error: (Each undeclared identifier is reported only once libvo/cocoa_common.m:146: error: for each function it appears in.) libvo/cocoa_common.m:146: warning: no '-setActivationPolicy:' method found libvo/cocoa_common.m:146: warning: (Messages without a matching method signature libvo/cocoa_common.m:146: warning: will be assumed to return 'id' and accept libvo/cocoa_common.m:146: warning: '...' as arguments.) libvo/cocoa_common.m: In function 'vo_cocoa_uninit': libvo/cocoa_common.m:154: error: 'NSApplicationPresentationDefault' undeclared (first use in this function) libvo/cocoa_common.m:154: warning: no '-setPresentationOptions:' method found libvo/cocoa_common.m: In function '-[GLMPlayerWindow fullscreen]': libvo/cocoa_common.m:421: error: 'NSApplicationPresentationHideDock' undeclared (first use in this function) libvo/cocoa_common.m:421: error: 'NSApplicationPresentationHideMenuBar' undeclared (first use in this function) libvo/cocoa_common.m:421: warning: no '-setPresentationOptions:' method found libvo/cocoa_common.m:424: warning: 'GLMPlayerWindow' may not respond to '-setStyleMask:' libvo/cocoa_common.m:431: error: 'NSApplicationPresentationDefault' undeclared (first use in this function) libvo/cocoa_common.m:431: warning: no '-setPresentationOptions:' method found libvo/cocoa_common.m:433: warning: 'GLMPlayerWindow' may not respond to '-setStyleMask:' libvo/cocoa_common.m: In function '-[GLMPlayerWindow applicationWillBecomeActive:]': libvo/cocoa_common.m:577: error: 'NSApplicationPresentationHideDock' undeclared (first use in this function) libvo/cocoa_common.m:578: error: 'NSApplicationPresentationHideMenuBar' undeclared (first use in this function) libvo/cocoa_common.m:578: warning: no '-setPresentationOptions:' method found libvo/cocoa_common.m: In function '-[GLMPlayerWindow applicationWillResignActive:]': libvo/cocoa_common.m:585: error: 'NSApplicationPresentationDefault' undeclared (first use in this function) libvo/cocoa_common.m:585: warning: no '-setPresentationOptions:' method found make: *** [libvo/cocoa_common.o] Error 1 }}} -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:17> MacPorts <http://www.macports.org/> Ports system for Mac OS

#35177: mplayer2 fails to compile: conflicting types for 'Cursor' ---------------------------------------+------------------------------------ Reporter: samuel.bateman@… | Owner: cal@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: haspatch Port: mplayer2 | ---------------------------------------+------------------------------------ Changes (by cal@…): * status: new => closed * resolution: => fixed Comment: It doesn't seem there's anything I can do here to make mplayer2 work on 10.5. Try reporting upstream or adapting the Portfile to disable the offending parts (probably --disable-cocoa). If you can come up with a patch to fix the build on 10.5 I'll be happy to apply it. -- Ticket URL: <https://trac.macports.org/ticket/35177#comment:19> MacPorts <http://www.macports.org/> Ports system for Mac OS