[MacPorts] #28356: eggdrop: minimize use of "system"
#28356: eggdrop: minimize use of "system" -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: dre@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: eggdrop -------------------------------------+-------------------------------------- The eggdrop portfile includes this line: {{{ post-destroot { system "cd ${destroot}${prefix}/bin/ && rm ../share/eggdrop/eggdrop && ln -s ../share/eggdrop/eggdrop-${version} eggdrop && mv ../share/eggdrop/eggdrop.conf ../share/eggdrop/eggdrop.conf.sample && mv ../share/eggdrop/doc/man1/eggdrop.1 ../share/man/man1" }}} All of this can be done with native Tcl commands, which is preferable to using "system". -- Ticket URL: <https://trac.macports.org/ticket/28356> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28356: eggdrop: minimize use of "system" -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: dre@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: eggdrop -------------------------------------+-------------------------------------- Comment(by blackfrog1@…): I took each of the system command and converted them into the Tcl Extension. See attached port patch diff. -- Ticket URL: <https://trac.macports.org/ticket/28356#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28356: eggdrop: minimize use of "system" --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: dre@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: eggdrop | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Thanks, r77379 (maintainer timeout). -- Ticket URL: <https://trac.macports.org/ticket/28356#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts