[MacPorts] #17605: pspp-0.6.1 Portfile patch
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Added variants and default variants to the pspp portfile. Moved perl from depends_lib to depends_build. -- Ticket URL: <http://trac.macports.org/ticket/17605> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by jeremy@…): The diff is against r42203 instead of ticket number. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by jeremy@…): Further update: - formatting better matches the suggested styles - shell scripts added to include dylibs when invoking pspp binaries -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by mcalhoun@…): A few comments on the patch: * Whitespace changes almost always get a separate commit so it is easier to track changes. * If the port is installed without the ncurses variant but with ncursesw installed, won't this be a problem if ncursesw is subsequently uninstalled. This is not a problem with, for example, the graph variant due to --without-libplot. * Setting LD_LIBRARY_PATH is almost never necessary. Why can't psppir be called directly? * I can not remember where I read it, but useful functionality shouldn't be split off into a variant without a compelling reason. Is that the case with pspp? Personally, I have found most variants to be more trouble than they are worth. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by jeremy@…): Thanks for the comments mcalhoun. * I was originally going to do the whitespace changes in a separate diff but this ticket was already open so I figured I'd just go ahead and put everything into the open ticket to save time (It's been open for 4 weeks and is just now being looked at). I can pull it apart and do it separately if that's what should be done. * I required ncursesw for the variant versus the regular ncurses. According to the pspp INSTALL file, it is optional to include libncurses: "Without it, PSPP will assume it is running in an 80x25 terminal." * I had found a bug where pspp expects its dylibs to be in . or .. and the easiest solution I could think of was to wrap the path to the real ones through a shell script. Do you know a better solution? I'm open to ideas. * I created the variants to mimic pspp's own configure flags. The install file has these sections: required, graphing features, graphical features for psppire, ability to read gnumeric files, and other optionals like ncurses. I believe that mimicking the install options of pspp to be a good thing as far as variants go, especially since the default has then enabled (and you can disable what want). Let me know of changes you believe I should make and if these should be split into separate portfiles and I'll hammer them out today. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by mcalhoun@…): I applied the whitespace changes in r45130. Attached is an alternate patch file for the changes you wanted. I only included variants where it was possible to turn off the feature.[[BR]] For example, I could find no way of stopping the configure script from looking for the readline library. I modified the postgres variant because it was not actually finding the right libraries. I modified the variant tex (and renamed it to doc) because it was not actually building the documentation. I tried to find a way around the LD_LIBRARY_PATH problem using --disable- rpath.[[BR]] Please test if this solved the problem (I do not know how to cause the error). If you approve, I can commit the changes. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by jeremy@…): Thank you for the help mcalhoun. --disable-path did not solve the crash. You can recreate the crash by attempting to run a descriptive analysis on the data (really, anything that causes a new window to pop open). It can be found under the Analyze menu. I'm going to modify your patch to include the LD_LIBRARY_PATH and repost it. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by jeremy@…): If everything is in order, please apply patch Portfile-pspp.diff against r45130. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by mcalhoun@…): Replying to [comment:8 jeremy@…]:
If everything is in order, please apply patch Portfile-pspp.diff against r45130.
Forgive me, but I do not quite understand your latest Portfile- pspp.diff.[[BR]] It does not seem to be a diff against r45130. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: snc@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Changes (by snc@…): * owner: macports-tickets@… => snc@… * status: new => assigned -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17605: pspp-0.6.1 Portfile patch -----------------------------------------+---------------------------------- Reporter: jeremy@… | Owner: snc@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: portfile update Port: pspp | -----------------------------------------+---------------------------------- Changes (by snc@…): * status: assigned => closed * resolution: => fixed Comment: Changes committed in r45332. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts