[MacPorts] #18889: Push livecheck default settings into dports/_resources/port1.0
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Currently default values for various check types within livecheck are defined in [browser:trunk/base/src/port1.0/portlivecheck.tcl] and hence require updates to the base MacPorts release in order to update. The default values (eg, livecheck.url and livecheck.regex) for various built-in types (freshmeat, sourceforge, etc) should instead be set by a file in dports/_resources/port1.0 (like port groups and mirror sites). This would allow much easier and faster updates when things change (see ticket #18887). -- Ticket URL: <http://trac.macports.org/ticket/18889> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Comment(by perry@…): I've attached a patch for portlivecheck.tcl that sources _resource/port1.0/livecheck/defaults.tcl to load the default values. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Comment(by blb@…): Looks like a good start; what I'd really like to see (not sure how others feel) is the removal of anything site-specific (eg any reference to freshmeat, googlecode, etc) moved out of base and into the _resources path. Also, be done in such a way that new ones can be added only but updating that file in _resources. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Comment(by perry@…): I've attached a new patch that removes site-specific references in portlivecheck.tcl (attachment:patch-portlivecheck.tcl.2.diff). Each type (freshmeat, gnu, googlecode and sourceforge) has a corresponding .tcl file in dports/_resources/port1.0/livecheck (attachment:patch- _resources-port1.0-livecheck.diff ). In ports where no livecheck is specified (e.g., libsndfile), defaults are loaded from fallback.tcl, which is a symlink to one of the types (currently freshmeat). I've tested the patch with the following ports: * libsndfile: freshmeat (fallback) * ccaudio: gnu * mongoose: googlecode * lingon: sourceforge {{{ $ port -v livecheck libsndfile ccaudio mongoose lingon libsndfile seems to have been updated (port version: 1.0.19, new version: 0.9.48) ccaudio seems to have been updated (port version: 1.1.1, new version: 1.2.0) mongoose seems to be up to date Lingon seems to have been updated (port version: 2.1, new version: 2.1.1) }}} -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Comment(by perry@…): I should probably add that portlivecheck pattern matches filenames against mirrors (as defined in port1.0/fetch/mirror_sites.tcl) to determine which defaults file to load. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 ------------------------------+--------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Keywords: livecheck | Port: ------------------------------+--------------------------------------------- Comment(by perry@…): I've attached an example defaults file for gnome (attachment:gnome.tcl). I tested it with the ports esound and totem (note that I removed the livecheck portions of their Portfile before running livecheck). {{{ DEBUG: Loading the defaults from '/Users/perry/src/macports- trunk/dports/_resources/port1.0/livecheck/gnome.tcl' DEBUG: Fetching http://ftp.gnome.org/pub/gnome/sources/esound/0.2/ DEBUG: The regex is "LATEST-IS-(.*)"" DEBUG: The regex matched "LATEST-IS-0.2.41"", extracted "0.2.41" esound seems to be up to date }}} -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Changes (by perry@…): * status: new => closed * resolution: => fixed Comment: Committed in r51069. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * cc: perry@… (added) Comment: I notice that rsync doesn't seem to want to download the fallback.tcl symlink. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Comment(by blb@…): Hmm, that's weird. Perhaps fallback.tcl should just be {{{source freshmeat.tcl}}}? -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Comment(by perry@…): Replying to [comment:8 blb@…]:
Hmm, that's weird. Perhaps fallback.tcl should just be {{{source freshmeat.tcl}}}?
That's fine, though we'd be leaving a hard-coded value in portlivecheck.tcl (then again, I doubt that value will be changed anytime soon, if ever). -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Comment(by raimue@…): Replying to [comment:9 perry@…]:
That's fine, though we'd be leaving a hard-coded value in portlivecheck.tcl (then again, I doubt that value will be changed anytime soon, if ever).
Actually I intended to change it, because not many projects have a freshmeat page which is always up to date. Therefore it would probably be better to check the (first?) master_sites URL for files with a higher version number, as it is often a webserver directory listing. Could fallback.tcl be a one-liner sourcing the default? -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Comment(by perry@…): Replying to [comment:10 raimue@…]:
Could fallback.tcl be a one-liner sourcing the default?
Yeah, that'd work. I added the following to fallback.tcl. {{{ source [getdefaultportresourcepath "port1.0/livecheck"]/freshmeat.tcl }}} -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#18889: Push livecheck default settings into dports/_resources/port1.0 -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 1.8.0 Component: base | Version: 1.8.0 Resolution: fixed | Keywords: livecheck Port: | -------------------------------+-------------------------------------------- Comment(by perry@…): Replaced the symlink with a regular file that sources a default in r51434 and r51435. -- Ticket URL: <http://trac.macports.org/ticket/18889#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts