#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by jeremyhu@…): Possibly related to #31948 -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Description changed by jeremyhu@…: Old description:

{{{ /opt/local/libexec/apple-gcc42/gcc/i686-apple-darwin10/4.2.1/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.5.sdk test.c | grep usr/include| head -n 1 # 1 "/usr/include/stdio.h" 1 3 4 }}}

{{{ ~ $ /opt/local/libexec/apple-gcc42/gcc/i686-apple-darwin8/4.2.1/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c | grep usr/include| head -n 1 # 1 "/usr/include/stdio.h" 1 3 4 }}}

gcc42 (and the rest of the gcc ports) are ok: {{{ ~ $ /opt/local/libexec/gcc/i386-apple-darwin8.11.1/4.2.4/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c | grep usr/include| head -n 1 # 1 "/Developer/SDKs/MacOSX10.4u.sdk/usr/include/stdio.h" 1 3 4 }}}

New description: {{{ /opt/local/libexec/apple-gcc42/gcc/i686-apple-darwin10/4.2.1/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.5.sdk test.c | grep usr/include| head -n 1 # 1 "/usr/include/stdio.h" 1 3 4 }}} {{{ ~ $ /opt/local/libexec/apple-gcc42/gcc/i686-apple-darwin8/4.2.1/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c | grep usr/include| head -n 1 # 1 "/usr/include/stdio.h" 1 3 4 }}} gcc42 (and the rest of the gcc ports) are ok: {{{ ~ $ /opt/local/libexec/gcc/i386-apple-darwin8.11.1/4.2.4/cc1 -E -quiet -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c | grep usr/include| head -n 1 # 1 "/Developer/SDKs/MacOSX10.4u.sdk/usr/include/stdio.h" 1 3 4 }}} --- {{{ $ /opt/local/libexec/apple-gcc42/gcc/i686-apple-darwin8/4.2.1/cc1 -v -quiet -E -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c > /dev/null ignoring nonexistent directory "/opt/local/lib/apple-gcc42/gcc/i686-apple- darwin8/4.2.1/../../../../i686-apple-darwin8/include" #include "..." search starts here: #include <...> search starts here: /usr/local/include /opt/local/include /opt/local/lib/apple-gcc42/gcc/i686-apple-darwin8/4.2.1/include /usr/include /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks (framework directory) /Developer/SDKs/MacOSX10.4u.sdk/Library/Frameworks (framework directory) End of search list. $ /opt/local/libexec/gcc/i386-apple-darwin8.11.1/4.2.4/cc1 -v -quiet -E -isysroot /Developer/SDKs/MacOSX10.4u.sdk test.c > /dev/null ignoring nonexistent directory "/Developer/SDKs/MacOSX10.4u.sdk/opt/local/include" ignoring nonexistent directory "/opt/local/lib/gcc42/gcc/i386-apple- darwin8.11.1/4.2.4/../../../../i386-apple-darwin8.11.1/include" #include "..." search starts here: #include <...> search starts here: /opt/local/lib/gcc42/gcc/i386-apple-darwin8.11.1/4.2.4/include /Developer/SDKs/MacOSX10.4u.sdk/usr/include /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks /Developer/SDKs/MacOSX10.4u.sdk/Library/Frameworks End of search list. }}} -- -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by royliu@…): Give me a few days lead time -- I barely remember how I patched the compiler's search patch mechanism. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by jeremyhu@…): If you don't come up with the "real" solution soon (namely fixing p->add_sysroot to be false in this case), I'm just going to go with this work around as a stop-gap ... that will fix apple-gcc42, but the gccXX ports will still be broken. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by royliu@…): Never mind, my bad, please ignore the above. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by jeremyhu@…): I don't think that's the right solution. I believe the real fix is figuring out why p->add_sysroot is true and set it to false for the compiler's include path. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by jeremyhu@…): r93187 has my workaround, since your patch actually made things worse. I don't think you understand how -isysroot works. The sysroot is appended to certain include paths (but not all of them). -isysroot should NOT be appended to the *compiler's* include path because it needs to be found in $prefix (we assume MacPorts doesn't exist in an $SDK). Setting p->add_sysroot to false will cause the sysroot to NOT be appended, so that is what we want to do. Your change just rewrote the include path to be /usr/include ... My hack works by forcing that predicate to false based on checking for the "apple-gcc42" substring that will appear in the compiler's include directory, but the real fix is to make sure p->add_sysroot gets set to false for that entry. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:14> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly -----------------------------------+---------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: apple-gcc42 -----------------------------------+---------------------------------------- Comment(by royliu@…): I'm still not understanding how my patch made things worse. There are essentially two types of includes that are being addressed. They look like: {{{ /Applications/Xcode.app/Contents/Developer/usr/llvm-gcc-4.2/lib/gcc/i686 -apple-darwin11/4.2.1/include /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk/usr/include }}} I think the problem arises when Apple provides default compilers. These default compilers are installed in the default prefix, i.e., `/usr`. Apple also provides SDKs which serve as sysroots. A sysroot is a self- contained, alternate include hierarchy. Naturally, the internal structure of Apple SDKs use the `/usr` hierarchy to mirror their compiler installations, and it's all good. The MacPorts compiler is installed in `/opt/local`, and third party libraries are asking for `-isysroot` to be set to an Apple-provided SDK which uses the `/usr` hierarchy. This is the crux of the problem. The patch I made attempts to address the above two cases. In the first case, the include directory is compiler-specific, and so we actually want the MacPorts compiler's hierarchy, and drop the sysroot. In the second case, the user's intention is to use a "default" set of includes provided by the SDK. The best way I can think of is to: 1. Ignore `sysroot` for the compiler's include directory (the MacPorts compiler directory being invariant over SDKs). 2. Overwrite `/opt/local/include` with `/usr/include` when `sysroot` is about to be prepended, since that is what your vanilla Apple-provided compiler has access to. Is this set of policies what you had in mind? If not, what should be the correct set of includes for a MacPorts compiler when `-isysroot` is specified? If so, then can you give a case where my patch isn't correct? -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:16> MacPorts <http://www.macports.org/> Ports system for Mac OS

#34233: apple-gcc42 doesn't honor -isysroot correctly ------------------------------------+--------------------------------------- Reporter: jeremyhu@… | Owner: royliu@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Resolution: fixed | Keywords: Port: apple-gcc42 | ------------------------------------+--------------------------------------- Changes (by royliu@…): * status: new => closed * resolution: => fixed Comment: Very well. I'm closing this bug for now. -- Ticket URL: <https://trac.macports.org/ticket/34233#comment:18> MacPorts <http://www.macports.org/> Ports system for Mac OS