[MacPorts] #41226: gmt4 update to 4.5.11
#41226: gmt4 update to 4.5.11 -----------------------+-------------------------------- Reporter: florian@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: haspatch | Port: gmt4 -----------------------+-------------------------------- Attached is the Portfile patch to upgrade gmt4 from 4.5.9 to 4.5.11. -- Ticket URL: <https://trac.macports.org/ticket/41226> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Changes (by larryv@…): * keywords: haspatch => haspatch maintainer * owner: macports-tickets@… => takeshi@… * version: 2.2.1 => * cc: takeshi@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by florian@…): Unfortunately the first Mavericks bugs appeared, so I amended the Portfile patch and added two patchfiles. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by takeshi@…): Committed in r113124. BTW, the bug on strcpy has been annoying me in ncarg port. I am excited see a solution! Did you find the fix? If you know some other reference, let me know. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Changes (by takeshi@…): * status: new => closed * resolution: => fixed -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Changes (by takeshi@…): * status: closed => reopened * resolution: fixed => Comment: I got buildbot failures... It compiled OK on Mavericks. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Changes (by takeshi@…): * status: reopened => closed * resolution: => fixed Comment: Forgot to add patches. Committed in r113126. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by florian@…): Thanks. The issue with strcpy is actually not a Mavericks bug but a general issue because strcpy's behavior is undefined with overlapping strings (http://pubs.opengroup.org/onlinepubs/009695399/functions/strcpy.html). The "fix" in our case was to test whether the arguments of strcpy are the same (pointers equal). You could create a macro wrapper as such and include it early in the ncarg code: {{{ #define strcpy(a, b) {if (a!=b) strcpy (a, b)} }}} but this only catches identical pointers and not string overlaps. So you may be lucky or you may not. Btw, where would I see buildbot failures and logs? -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by takeshi@…): Go to https://build.macports.org/waterfall and click compile > stdio of the submitted changes. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by florian@…): Great, thanks! Oh, and I just noted that I accidentally uploaded attachment:patch-ps2raster.diff twice. You can remove gmt4/files/patch- ps2raster.2.diff from svn. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by takeshi@…):
The issue with strcpy is actually not a Mavericks bug but a general issue because strcpy's behavior is undefined with overlapping strings
Wow C is difficult! I deleted the duplicate patch in r113127. Thanks. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#41226: gmt4 @4.5.9_0: update to 4.5.11 ------------------------+--------------------------------- Reporter: florian@… | Owner: takeshi@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmt4 | ------------------------+--------------------------------- Comment (by florian@…): Thank you too for committing all the GMT relates changes. -- Ticket URL: <https://trac.macports.org/ticket/41226#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts