[MacPorts] #51626: ldas-tools-al
#51626: ldas-tools-al ------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: ldas-tools-al ------------------------+-------------------------------- This is the first package broken out of ldas-tools -- Ticket URL: <https://trac.macports.org/ticket/51626> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+-------------------------------- Changes (by mf2k@…): * keywords: haspatch => * version: 2.3.4 => Comment: See #51625. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+-------------------------------- Comment (by ryandesign@…): This port should not be marked as conflicting with ldas-tools. Your current ldas-tools submission is marked `replaced_by ldas-tools-as`. As such, the `conflicts` marking will prevent the replacement from working. My suggestion was to make ldas-tools a meta port; in that case, you would not want a `conflicts` marking either; instead, you would want to use the deactivate hack. You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether `configure.cxx_stdlib` equals `libc++`. The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+-------------------------------- Comment (by ryandesign@…): `configure.args-strsed` is ancient. You should probably use `configure .args-replace` instead. (`configure.args-replace --disable-python --enable-python`) It doesn't look like the livecheck has been updated for the changed distfile names. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+-------------------------------- Comment (by ed.maros@…): Replying to [comment:3 ryandesign@…]:
`configure.args-strsed` is ancient. You should probably use `configure .args-replace` instead. (`configure.args-replace --disable-python --enable-python`)
It doesn't look like the livecheck has been updated for the changed distfile names. I have opened a ticket for this on the main ticketing system for the software package and will make the modification for the next release of the software.
-- Ticket URL: <https://trac.macports.org/ticket/51626#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+---------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+---------------------- Changes (by ram@…): * owner: macports-tickets@… => ram@… * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: ldas-tools-al | ----------------------------+-------------------- Changes (by ram@…): * status: assigned => closed * resolution: => fixed Comment: r151455 -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+-------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: ldas-tools-al | ----------------------------+-------------------- Comment (by ryandesign@…): Replying to [comment:2 ryandesign@…]:
You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether `configure.cxx_stdlib` equals `libc++`.
The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax.
Replying to [comment:3 ryandesign@…]:
`configure.args-strsed` is ancient. You should probably use `configure .args-replace` instead. (`configure.args-replace --disable-python --enable-python`)
It doesn't look like the livecheck has been updated for the changed distfile names.
These issues should have been resolved before committing. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+---------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+---------------------- Changes (by ram@…): * status: closed => reopened * resolution: fixed => Comment: Apologies I was under the impression that these issues had been addressed, I didn't check too closely. Ed: Can you get a patch together to address these issues? -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+---------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+---------------------- Comment (by ed.maros@…): Replying to [comment:8 ram@…]:
Apologies I was under the impression that these issues had been addressed, I didn't check too closely.
Ed: Can you get a patch together to address these issues?
The patch file addresses all of the issues mentioned above. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+---------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+---------------------- Comment (by ram@…): Thanks Ed, Ryan: Are you happy with these changes? -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#51626: ldas-tools-al ----------------------------+---------------------- Reporter: ed.maros@… | Owner: ram@… Type: submission | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools-al | ----------------------------+---------------------- Changes (by ram@…): * cc: ryandesign@… (added) Comment: Ryan: Do the attached changes address your concerns? -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:11> MacPorts <https://www.macports.org/> Ports system for macOS
#51626: ldas-tools-al ----------------------------+-------------------- Reporter: ed.maros@… | Owner: skymoo Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: ldas-tools-al | ----------------------------+-------------------- Changes (by skymoo): * status: reopened => closed * resolution: => fixed Comment: I'm with with Ed off list on an update to this port that address these issues along with updating to the next version. I'm going to close this ticket out as to avoid confusion when we're ready to submit the update. -- Ticket URL: <https://trac.macports.org/ticket/51626#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts