[MacPorts] #41499: py26-pyke @1.1.1: make it a unified py-pyke port
#41499: py26-pyke @1.1.1: make it a unified py-pyke port -----------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: py-pyke py26-pyke -----------------------------+-------------------------------- I propose to use the unified PortGroup for this port to add `py27` and `py3x` to it. Some time ago I created such a unified port, because I needed it as a dependence. I than realised that the `py26-pyke` version already exists. The differences are minor, but I propose some changes (as detailed below) here so I just submit my `Portfile` as is for review, I can provide diffs if this is considered useful in this case (`py26-pyke` is to be replaces `py-pyke`). The maintainer probably should stay with `mahergamal@gmail.com`. The differences are: - use unified PortGroup; - add py27 py32 py33 py34 - add `license` and `supported_archs noarch`; - the description is slightly different; - remove lib dependency; The dependency `htmltemplate` is used only for examples, so it should not be a dependency (or at best a `depends_run`). -- Ticket URL: <https://trac.macports.org/ticket/41499> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Changes (by ryandesign@…): * cc: jmr (removed) * cc: jmr@… (added) -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Comment (by mojca@…): I'm working on this now, just a question: the original port has {{{ depends_lib port:py26-htmltemplate }}} What's with this dependency? -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Comment (by mojca@…): Sorry, I just read that in description. I'm not sure whether or not to add `depends_run` now. In any case one would need to fix the dependency to support more versions of Python. -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Comment (by Peter.Danecek@…): I concluded I is not necessary, see also above. `htmltemplate` is required only for the examples not even tests. At best this would qualify for a runtime dependency, but I just would not put it. -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Changes (by mojca@…): * status: new => closed * resolution: => fixed Comment: r114092. I assumed maintainer timeout, but also added you as the co- maintainer. If the original author disagrees or if you disagree with the change, let me know. I had to add {{{ worksrcdir pyke-${version} }}} else the build failed, trying to find the dir `work/pyke3-1.1.1`. -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#41499: py26-pyke @1.1.1: make it a unified py-pyke port --------------------------------+-------------------------------- Reporter: Peter.Danecek@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: py-pyke py26-pyke | --------------------------------+-------------------------------- Comment (by Peter.Danecek@…): Thanks for having work on this and for spotting the bug. I tested py3 as well, but probably did some "minor" change on the py3 logic and broke it unintentionally. -- Ticket URL: <https://trac.macports.org/ticket/41499#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts