[MacPorts] #37954: Cleanup whitespace in SBCL Portfile.
#37954: Cleanup whitespace in SBCL Portfile. -------------------------+-------------------------------- Reporter: crossd@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Keywords: haspatch | Port: sbcl -------------------------+-------------------------------- Clean up whitespace and formatting in the SBCL Portfile. -- Ticket URL: <https://trac.macports.org/ticket/37954> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Changes (by jmr@…): * owner: macports-tickets@… => easieste@… * cc: easieste@… (removed) * cc: gwright@… (added) * version: 2.1.3 => -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: wontfix | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Changes (by easieste@…): * status: new => closed * resolution: => wontfix Comment: As I understand things, the current [MacPorts convention is to use space for whitespace, not tab characters][4.7.1], a convention that I fully support. JWZ has a [nice rant][jwz] summarizing the debate fairly succinctly from a pro-space position. Closing the ticket as "wontfix", but I suppose there will be a little further debate. If the "tab" side wins, one should change the autoset variables for Emacs/VIM in the headers as well. [4.7.1] http://guide.macports.org/chunked/development.practices.html [jwz]: http://www.jwz.org/doc/tabs-vs-spaces.html] -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Changes (by larryv@…): * status: closed => reopened * resolution: wontfix => Comment: Correct, portfiles use 4-space indentation. However, on account of how ugly the sbcl portfile currently is, I’ve applied crossd’s patch and just converted the tabs to spaces. -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Changes (by larryv@…): * status: reopened => closed * resolution: => fixed Comment: r102702. -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Comment (by crossd@…): Thanks! Sorry about the tabs; I thought I had run 'expand' to covert them to spaces before sending the patch, but I had not. :-/ -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37954: Cleanup whitespace in SBCL Portfile. --------------------------+------------------------ Reporter: crossd@… | Owner: easieste@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: sbcl | --------------------------+------------------------ Comment (by jmr@…): Just to clarify, the policy is that indent style is up to the maintainer, but should be consistent throughout the file and correctly indicated in the modeline (if present). 4 spaces is recommended but not required. -- Ticket URL: <https://trac.macports.org/ticket/37954#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts