[MacPorts] #29704: go portfile creates bad symlinks
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: --------------------------------+------------------------------------------- Hi, Installing "go" creates a symbolic link /src/Make.*, instead of a separate link for each individual make file. 116 # gomake command required makefiles 117 ln -s ${prefix}/src/${name}/${name}-${version}/src/Make.* ${destroot}${prefix}/src Seems to be related to changes from Ticket #29321 I can't find an example in other Portfiles that tries to make symlinks like this, so I don't have a fix/patch. (I changed mine to use xinstall instead of making symbolic links, plus other changes to install without root privileges. I think the package maintainer might do it a different way instead) Thanks Caleb -- Ticket URL: <https://trac.macports.org/ticket/29704> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: go --------------------------------+------------------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) * owner: macports-tickets@… => singingwolfboy@… * port: => go Comment: The fix is to use an "eval glob" construct. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: go --------------------------------+------------------------------------------- Comment(by ryandesign@…): Or possibly an fs-traverse loop. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: go --------------------------------+------------------------------------------- Changes (by ryandesign@…): * keywords: => haspatch Comment: Or neither of those. ("eval ... [glob ...]" would work if MacPorts' ln supported creating multiple links at once, like the shell's ln does, but it doesn't seem to.) The attached patch uses a "foreach ... [glob ...]" and seems to work. Perhaps this should be committed together with the fix in #29706. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: go --------------------------------+------------------------------------------- Comment(by ryandesign@…): No wait, this patch is wrong, needs to glob the files in the destroot... -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: go --------------------------------+------------------------------------------- Comment(by ryandesign@…): Here's the fixed version. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks --------------------------------+------------------------------------------- Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: go --------------------------------+------------------------------------------- Changes (by singingwolfboy@…): * status: new => assigned Comment: Thanks! Verifying your patch on my computer now: it if builds cleanly and fixes the issue, I'll commit it. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29704: go portfile creates bad symlinks ---------------------------------+------------------------------------------ Reporter: cgilmour@… | Owner: singingwolfboy@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: haspatch Port: go | ---------------------------------+------------------------------------------ Changes (by singingwolfboy@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r79186. -- Ticket URL: <https://trac.macports.org/ticket/29704#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts