[MacPorts] #43585: terra @ 0.7 use MacPorts defaults for compiler and options
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ----------------------------------+-------------------------------- Reporter: tlockhart1976@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: haspatch, maintainer | Port: terra ----------------------------------+-------------------------------- This updated Portfile and restructured patch files use compilers and options from the MacPorts configure.cc, configure.cxx, and configure.optflags settings. Patch files are renamed to the MacPorts standard as indicated by "port lint --nitpick". The original patch file "terra.patches" is no longer used and can be deleted. Per feedback from Ryan and Bradley. -- Ticket URL: <https://trac.macports.org/ticket/43585> MacPorts <http://www.macports.org/> Ports system for OS X
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ------------------------------+---------------------------------- Reporter: tlockhart1976@… | Owner: pixilla@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch, maintainer Port: terra | ------------------------------+---------------------------------- Changes (by pixilla@…): * owner: macports-tickets@… => pixilla@… * cc: pixilla@… (removed) Comment: My initial commit did not include the correct files. Fixes (including Ryans) will be committed shortly. -- Ticket URL: <https://trac.macports.org/ticket/43585#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ------------------------------+---------------------------------- Reporter: tlockhart1976@… | Owner: pixilla@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch, maintainer Port: terra | ------------------------------+---------------------------------- Comment (by pixilla@…): Tom: Ryan: Does r119779 implement the corrections properly? -- Ticket URL: <https://trac.macports.org/ticket/43585#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ------------------------------+---------------------------------- Reporter: tlockhart1976@… | Owner: pixilla@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch, maintainer Port: terra | ------------------------------+---------------------------------- Comment (by tlockhart1976@…): Replying to [comment:2 pixilla@…]:
Tom: Ryan: Does r119779 implement the corrections properly? Looks fine to me. I left in the patching on the Makefile but then replaced some of the results with reinplace substitutions per Ryan. I think that should be OK, and keeping the patches acts as a marker for all of the places which need to be updated in that file.
-- Ticket URL: <https://trac.macports.org/ticket/43585#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ------------------------------+---------------------------------- Reporter: tlockhart1976@… | Owner: pixilla@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch, maintainer Port: terra | ------------------------------+---------------------------------- Comment (by pixilla@…): Replying to [comment:3 tlockhart1976@…]:
Replying to [comment:2 pixilla@…]:
Tom: Ryan: Does r119779 implement the corrections properly? Looks fine to me. I left in the patching on the Makefile but then replaced some of the results with reinplace substitutions per Ryan. I think that should be OK, and keeping the patches acts as a marker for all of the places which need to be updated in that file.
It is good to know when a file changes enough to cause a patch to fail rather then have reinplace simply miss and the build continue. -- Ticket URL: <https://trac.macports.org/ticket/43585#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#43585: terra @ 0.7 use MacPorts defaults for compiler and options ------------------------------+---------------------------------- Reporter: tlockhart1976@… | Owner: pixilla@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: haspatch, maintainer Port: terra | ------------------------------+---------------------------------- Changes (by pixilla@…): * status: new => closed * resolution: => fixed Comment: See r119779 -- Ticket URL: <https://trac.macports.org/ticket/43585#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts