#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ryandesign@…): The license should be listed as "public-domain" (no spaces in license names). The line "extract.mkdir no" can be removed; that's the default. There is a github portgroup that could be used, but for this port it might not actually help simplify anything. -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by macsforever2000@…): This port does not properly use the unified python portgroup. 1. Change {{{categories}}} to {{{categories-append}}} to not overwrite the python category 1. Change {{{depends_lib}}} to {{{depends_lib-append}}} to not overwrite required dependencies 1. The dependencies themselves must be written like {{{port:py${python.version}-numpy}}} 1. The entire depends_lib-append lines must be placed inside a {{{if {$subport != $name} {}}} block 1. Did the listed maintainer agree to maintain this port? -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ben@…): macsforever2000 - I've updated the port file to account for your suggestions: 2 and 3 (I've uploaded a new port file, portfile 3, as well as a diff -- a diff to the original). I did not do the others for the following reasons: 1) This script isn't a python module. In fact it has nothing to do with python other than it is written in it. What it is is a command line tool for economist that goes with a paper we just submitted to JUE studying firm agglomeration. Generally when you look through the macports categories, the category they are in depends on what they do, not what they are written in. 4) I've tested it with a if {$subport != $name} { block and it results in the dependancies not being installed when they are not already installed 5) The maintainer is me, but that address is associated to my university address. For the same reason as 1, I have not renamed it to py-EGSimulation. -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by macsforever2000@…): See the ROOT port for an example among many others. -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by macsforever2000@…): Unless you name the port "py-EGSimulation" and use subports, there is no way to choose py26. So this really cannot work. Have you tried it? I've never seen the unified python portgroup used in this way before. Unfortunately it is not fully documented yet. Also, you do not need to attach diffs. This is a new port and only the latest portfile matters. -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ben@…): I haven't heard any comments on portfile.5; does that mean everyone is ok with it? If not please let me know what I need to do to make it so. -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation -------------------------+-------------------------------- Reporter: ben@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by pixilla@…): Replying to [comment:12 snc@…]:

[attachment:Portfile.5] still seems written like a python module.

You should remove the PortGroup and simply use depends_run-append port:python27 (whichever depends_* are appropriate for your needs). The ports use setup.py and not configure/make. Isn't it nice to use the python PortGroup in this case?

-- Ticket URL: <https://trac.macports.org/ticket/36690#comment:13> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36690: EGSimulation ---------------------------+-------------------------- Reporter: ben@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: Port: EGSimulation | ---------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Thanks for this port! I've committed it in r99349 with these changes: * made use of github portgroup * added required "platforms" variable * removed "python.default_version 27" since that's the default * fixed livecheck * rearranged some lines -- Ticket URL: <https://trac.macports.org/ticket/36690#comment:15> MacPorts <http://www.macports.org/> Ports system for Mac OS