[MacPorts] #43155: qalculate-gtk fails build on Mavericks
#43155: qalculate-gtk fails build on Mavericks -------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: qalculate-gtk -------------------------+-------------------------------- qalculate-gtk fails to build on Mavericks. As per macsforever2000 (ticket #42889): {{{ :info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build ./support.h:25:21: note: expanded from macro '_' :info:build # define _(String) dgettext (PACKAGE, String) :info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build callbacks.cc:12498:38: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] :info:build pos_str = g_strdup_printf("%i", i_column + 1 + matrix_edit_columns.size() * gtk_tree_path_get_indices(path)[0]); :info:build ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build %lu :info:build callbacks.cc:12662:38: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] :info:build pos_str = g_strdup_printf("%i", i_column + 1 + matrix_columns.size() * gtk_tree_path_get_indices(path)[0]); :info:build ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build %lu :info:build In file included from callbacks.cc:30: :info:build In file included from ./callbacks.h:24: :info:build In file included from ./main.h:33: :info:build In file included from /opt/local/include/libqalculate/qalculate.h:15: :info:build In file included from /opt/local/include/libqalculate/includes.h:21: :info:build In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/vector:265: :info:build In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__bit_reference:15: :info:build /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:685:97: error: invalid operands to binary expression ('const tree_struct' and 'const tree_struct') :info:build _LIBCPP_INLINE_VISIBILITY bool operator()(const _T1& __x, const _T1& __y) const {return __x < __y;} :info:build ~~~ ^ ~~~ }}} -- Ticket URL: <https://trac.macports.org/ticket/43155> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: qalculate-gtk | ----------------------------+-------------------------------- Changes (by macsforever2000@…): * cc: mojca@… (added) -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: qalculate-gtk | ----------------------------+-------------------------------- Comment (by ionic@…): Right... doing what clang suggests makes qalculate-gtk compile. I fixed the issue locally on my system whilst building, but was obviously too lazy to make a real patch. I'll get that, as dirty as it may be. Really wish qalculate would have been updated within the last 4 years. :( -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: qalculate-gtk | ----------------------------+-------------------------------- Comment (by ionic@…): The other compile warnings are just that, warnings. We can ignore them (although they hint at bad code quality, but that's an upstream problem...) -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: qalculate-gtk | ----------------------------+-------------------------------- Changes (by mk@…): * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: qalculate-gtk | ----------------------------+-------------------------------- Comment (by ionic@…): I'd call this maintainer timeout. -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch Port: qalculate-gtk | ----------------------------+-------------------------------- Comment (by jjstickel@…): Yep, feel free to commit this without my input. I am still on Mountain Lion anyway. I'll try to take a look at this in the next couple weeks to make sure it didn't break anything, though. -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#43155: qalculate-gtk fails build on Mavericks ----------------------------+-------------------------------- Reporter: jjstickel@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: haspatch Port: qalculate-gtk | ----------------------------+-------------------------------- Changes (by mk@…): * status: new => closed * resolution: => fixed Comment: Fixed in r121596 -- Ticket URL: <https://trac.macports.org/ticket/43155#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts