#36130: New port for Bob --------------------------------+-------------------------------- Reporter: andre.dos.anjos@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Changes (by ciserlohn@…): * keywords: new port => Comment: Hi, thanks for your submission. Some remarks regarding your portfile: {{{ maintainers anjos }}} This means anjos<at>macports.org. It should be removed. {{{ depends_build port:cmake }}} can be removed as this is implied by the cmake port group. {{{ homepage http://idiap.github.com/bob/ }}} Ports for projects hosted on github should be using the github portgroup. {{{ build.target all destroot.target install use_parallel_build yes }}} These are all the default values. There's no need to explicitly include them in the port file. {{{ configure.compiler llvm-gcc-4.2 #clang remains untested at this point }}} should be replaced with: {{{ compiler.blacklist clang }}} Consider using the test phase (see http://guide.macports.org/#reference.phases.test) instead of {{{ variant unittest description "Runs unit tests after compilation." {} }}} and the related steps in the pre-destroot. And please don't add arbitrary keywords (see [wiki:DraftKeywordGuidelines]). The ticket type 'submission' is unambiguous. -- Ticket URL: <https://trac.macports.org/ticket/36130#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36130: New port for Bob --------------------------------+------------------------- Reporter: andre.dos.anjos@… | Owner: ciserlohn@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | --------------------------------+------------------------- Changes (by ciserlohn@…): * owner: macports-tickets@… => ciserlohn@… Comment: Replying to [comment:2 andre.dos.anjos@…]:

Ok, all done. Portfile-v2 attached.

Ok, more comments to come. I'll attach the current state of the portfile. But by now the port doesn't compile: {{{ Scanning dependencies of target pybob_db_arface_sqlite make[2]: Leaving directory `/opt/local/var/macports/build/_Users_ci_devel_repos_macports_trunk_dports_science_bob/bob/work/bob-1.0.6' make[2]: Entering directory `/opt/local/var/macports/build/_Users_ci_devel_repos_macports_trunk_dports_science_bob/bob/work/bob-1.0.6' make[2]: *** No rule to make target `databases/arface.sql3', needed by `python/db/CMakeFiles/pybob_db_arface_sqlite'. Stop. make[2]: Leaving directory `/opt/local/var/macports/build/_Users_ci_devel_repos_macports_trunk_dports_science_bob/bob/work/bob-1.0.6' make[1]: *** [python/db/CMakeFiles/pybob_db_arface_sqlite.dir/all] Error 2 make[1]: Leaving directory `/opt/local/var/macports/build/_Users_ci_devel_repos_macports_trunk_dports_science_bob/bob/work/bob-1.0.6' make: *** [all] Error 2 }}} Any ideas/suggestions. -- Ticket URL: <https://trac.macports.org/ticket/36130#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36130: New port for Bob --------------------------------+------------------------- Reporter: andre.dos.anjos@… | Owner: ciserlohn@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | --------------------------------+------------------------- Comment (by ciserlohn@…): @André Anjos: Please have a look at the attached log file. The python25 variant doesn't compile. -- Ticket URL: <https://trac.macports.org/ticket/36130#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36130: New port for Bob --------------------------------+------------------------- Reporter: andre.dos.anjos@… | Owner: ciserlohn@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | --------------------------------+------------------------- Comment (by ciserlohn@…): @André Anjos: Please have a look at the latest portfile. I think it's ready for inclusion. The main changes are: * revert the usage of the github portgroup. The portgroup is intended to fetch the tarball for a particular tag. In your case it has no advantage, it just complicates the portfile * check if boost is installed with the matching python variant, error out otherwise. * fix test phase usage * actually use 4 space indentation as stated in the modeline. There is only one thing left I want to discuss. Do you really have 6 maintainers? In the first version of the portfile you were the only maintainer. Usually a port has one maintainer, sometimes two. Very few ports have more than two maintainers. Note that the 'maintainers' keyword lists the maintainer of the port in MacPorts, not the upstream maintainers. -- Ticket URL: <https://trac.macports.org/ticket/36130#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS

#36130: New port for Bob --------------------------------+------------------------- Reporter: andre.dos.anjos@… | Owner: ciserlohn@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: Port: | --------------------------------+------------------------- Changes (by ciserlohn@…): * status: new => closed * resolution: => fixed Comment: Committed in r98241. -- Ticket URL: <https://trac.macports.org/ticket/36130#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS