#44300: Portfile for Salt 2014.1.7 ---------------------+-------------------------------- Reporter: cr@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: salt | ---------------------+-------------------------------- Changes (by mf2k@…): * priority: High => Normal * keywords: salt salt-master salt-minion saltstack => * version: 2.3.1 => Comment: The Priority field is for use by Macports team members only. [https://guide.macports.org/#development.patches Per the guidelines], please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. -- Ticket URL: <https://trac.macports.org/ticket/44300#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#44300: salt: update to 2014.1.7 ---------------------+--------------------------------- Reporter: cr@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: salt | ---------------------+--------------------------------- Comment (by ryandesign@…): The github portgroup should be used. If possible, fetch from the github- generated tarball instead of directly from the git repository. See comments in the github portgroup for instructions. Why are any of the variants needed? All they seem to do is install additional files, which the user can use if desired. Why not just always install these files? -- Ticket URL: <https://trac.macports.org/ticket/44300#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#44300: salt: update to 2014.1.7 ---------------------+--------------------------------- Reporter: cr@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: salt | ---------------------+--------------------------------- Comment (by mf2k@…): Why do you add {{{notes-append}}} in a {{{post-destroot}}} block? It seems that you should simply use "notes" and not in any block. -- Ticket URL: <https://trac.macports.org/ticket/44300#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#44300: salt: update to 2014.1.7 ---------------------+--------------------------------- Reporter: cr@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: salt | ---------------------+--------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: Thanks, but there are still numerous issues: * The patch does not apply. For example, the patch wants to delete a line "`# Portfile for saltstack`" but no such line is in the portfile. (That line was in the portfile that was submitted in #41191 but I did not commit that line because it didn't tell us anything we didn't already know.) Be sure you're generating your diff based on the latest version of the portfile that's currently in our repository. * You're fetching from git. Do you really need to? Usually we want to fetch from a tarball, which is what the github portgroup will do unless you specify otherwise. You shouldn't need to set git.url or git.branch or livecheck; running github.setup sets those for you. You may just need to add "`v`" as the 4th argument to github.setup. That's the tag prefix. * Is there any difference between the automatically created repository tag tarball and the manually uploaded release tarball? Possibly you may want to use the release tarball instead. If so, use "`github.tarball_from releases`" * If you're going to mess with the user's /etc in post-activate, you should undo it in pre-deactivate. * Instead of "`file link`", you should use "`ln -s`" * Instead of "`file copy`", you can just use "`copy`" * When you copy items into /Library/LaunchDaemons, please do it as part of the destroot phase, installing into ${destroot}/Library/LaunchDaemons, so that it will be cleaned up when the port is uninstalled * The second time you link /etc/salt to /opt/local/etc/salt seems to be unnecessary (and, besides, hardcodes /opt/local) -- Ticket URL: <https://trac.macports.org/ticket/44300#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X