[MacPorts] #30796: detex @2.8 Compile error - build failure
#30796: detex @2.8 Compile error - build failure -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: | Port: -------------------------------------+-------------------------------------- On Mac OS X Lion (and Xcode 4.2), when trying to install detex I get a compile failure which seems to be because clang is more fussy about code quality. I've attached the build log. -- Ticket URL: <https://trac.macports.org/ticket/30796> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex @2.8 Compile error - build failure -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: | Port: detex -------------------------------------+-------------------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * port: => detex -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex @2.8 Compile error - build failure -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: | Port: detex -------------------------------------+-------------------------------------- Comment(by ryandesign@…): I have sent the developer of detex a link to this ticket. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex @2.8 Compile error - build failure -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: | Port: detex -------------------------------------+-------------------------------------- Comment(by roy@…): I've had the same problem. The source code appears sloppy respecting missing return values. Not quite sure why. I guess it must be a legacy C "feature." Managed to get it to compile on Lion using Xcode 4.2 tools by adding `-Wno-return-type` to the compile-time options. Did this by naughtily patching the patch file! See attached `patch-Makefile.diff` file. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex: non-void function 'InputFile' should return a value [-Wreturn-type] -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: haspatch | Port: detex -------------------------------------+-------------------------------------- Changes (by ryandesign@…): * cc: roy@… (added) * keywords: => haspatch Comment: Roy, it looks like your patch also adds `-DNO_MALLOC_DECL`; is that also necessary to fix this problem? -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex: non-void function 'InputFile' should return a value [-Wreturn-type] -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: haspatch | Port: detex -------------------------------------+-------------------------------------- Comment(by roy@…): Dear Ryan, I didn't add that; it was already there. I just added the no- warning option in addition. I assume it need the NO_MALLOC_DECL too. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex: non-void function 'InputFile' should return a value [-Wreturn-type] -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: haspatch | Port: detex -------------------------------------+-------------------------------------- Comment(by ryandesign@…): Your patch shows that the line was previously commented out, as in not being used at all. Now you uncommented it which cause that option to be used. I just don't know the significance of adding that option so I'd prefer not to add it if it's not necessary to solve this problem. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex: non-void function 'InputFile' should return a value [-Wreturn-type] -------------------------------------+-------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: haspatch | Port: detex -------------------------------------+-------------------------------------- Comment(by roy@…): Ah, that's where my naughtiness came in. I patched the patch, by just editing the patch file. So the original patch uncommented. My patch-patch uncommented and added a new option! Naughty. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#30796: detex: non-void function 'InputFile' should return a value [-Wreturn-type] --------------------------------------+------------------------------------- Reporter: graham.dennis@… | Owner: ryandesign@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Resolution: fixed | Keywords: haspatch clang Port: detex | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * keywords: haspatch => haspatch clang * status: new => closed * resolution: => fixed Comment: Oh! Now I understand. I can reproduce the problem with clang on Snow Leopard with Xcode 3.2.6. Committed your patch in r84883. Thanks. -- Ticket URL: <https://trac.macports.org/ticket/30796#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts