[MacPorts] #40228: cmake: add FindLua52.cmake
#40228: cmake: add FindLua52.cmake -------------------------+------------------------- Reporter: mojca@… | Owner: css@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: cmake wxLua -------------------------+------------------------- This needs to be reported upstream, but it might take a while before they do anything and release a new version. {{{wxLua}}} needs {{{FindLua52.cmake}}} in order to compile with external dependency (otherwise it can still use the built-in lua, but not the external one). -- Ticket URL: <https://trac.macports.org/ticket/40228> MacPorts <http://www.macports.org/> Ports system for OS X
#40228: cmake: add FindLua52.cmake --------------------------+------------------- Reporter: mojca@… | Owner: css@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: cmake wxLua | --------------------------+------------------- Comment (by css@…): The upstream bug for this is http://www.cmake.org/Bug/view.php?id=14224 and it looks like the implementation may be somewhat different. I would prefer to wait for the upstream 2.8.12 release. That is, unless the generalized version-agnostic [http://cmake.org/gitweb?p=cmake.git;a=blob_plain;f=Modules/FindLua.cmake;hb=... FindLua.cmake] works with 2.8.11. Could one of you who uses Lua see if it does? -- Ticket URL: <https://trac.macports.org/ticket/40228#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#40228: cmake: add FindLua52.cmake --------------------------+---------------------- Reporter: mojca@… | Owner: css@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: cmake wxLua | --------------------------+---------------------- Changes (by css@…): * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/40228#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#40228: cmake: add FindLua52.cmake --------------------------+---------------------- Reporter: mojca@… | Owner: css@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: cmake wxLua | --------------------------+---------------------- Comment (by mojca@…): Waiting for 2.8.12 sounds perfectly fine (even though I have a hard time believing that this patch would be included in 2.8.12 given that RC3 is already out; if I was the developer I wouldn't dare changing the name of the module from RC3 to main release). In any case fixing this in 2.8.11/12 only makes sense if the solution will be the same as in the to-be-released version. It's pointless to add one file now and realize that a completely different solution will be used in the released version. Probably the main problem is that upstream software (like `wxLua`) expects the module to have a specific name (`wxLua` looks for `FindLua52.cmake` for example). I totally agree that it makes more sense to have version- agnostic `FindLua.cmake` rather than a separate module for each version. This `FindLua52.cmake` was just my quick-and-dirty solution to make the compilation work in the first place (lacking the experience to write a version-independent one). Meanwhile I will try to open a ticket in the tracker for wxLua. -- Ticket URL: <https://trac.macports.org/ticket/40228#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts