#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by mojca@…): Just a few questions before committing: * Did you plan to include some code related to the (conflicting) python variants? * We might want to address ticket #44224 (maybe by blacklisting compilers), but I'm not sure how and it's low priority anyway. * Somewhere on the "TODO" list I have the following chunk of code left (probably it needs to be tested and compared with ROOT 6): {{{ +# make sure that the proper variant is automatically selected +# (ROOT crashes if the compiler it was built with doesn't exist) +if {![variant_isset clang33] && ![variant_isset clang34] && ![variant_isset clang35]} { + if { ${configure.compiler} eq "macports-clang-3.3" } { + default_variants-append +clang33 + } elseif { ${configure.compiler} eq "macports-clang-3.4" } { + default_variants-append +clang34 + } elseif { ${configure.compiler} eq "macports-clang-3.5" } { + default_variants-append +clang35 + } +} }}} -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by jonesc@…): Replying to [comment:1 mojca@…]:

Just a few questions before committing: * Did you plan to include some code related to the (conflicting) python variants?

I don't think anything needs updating in the root5 port for this... It should not have the same issues as the root6 port has. ... Or has my memory missed something ?

* We might want to address ticket #44224 (maybe by blacklisting compilers), but I'm not sure how and it's low priority anyway.

I also do not know how...

* Somewhere on the "TODO" list I have the following chunk of code left (probably it needs to be tested and compared with ROOT 6): {{{ +# make sure that the proper variant is automatically selected +# (ROOT crashes if the compiler it was built with doesn't exist) +if {![variant_isset clang33] && ![variant_isset clang34] && ![variant_isset clang35]} { + if { ${configure.compiler} eq "macports-clang-3.3" } { + default_variants-append +clang33 + } elseif { ${configure.compiler} eq "macports-clang-3.4" } { + default_variants-append +clang34 + } elseif { ${configure.compiler} eq "macports-clang-3.5" } { + default_variants-append +clang35 + } +} }}}

Yeah, I guess this could be included. I confess I did forget this. Please feel free to add it if you like... Its less important I think as root5 does not use any macports clang compiler by default, due to blacklists etc. So I think in practise hardly any uses will use it, and then probably via the variant anyway. Chris -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by mojca@…): I'm not saying that this is a showstopper, but it's something I expected to fail based on problems in `root6`: {{{

port info root5 +python27 Error: Cannot install root5 with +python27 variant Error: Unable to open port: root6 port is already installed with +python27 and both cannot be active at once. Pick a different python variant. }}}

-- Ticket URL: <https://trac.macports.org/ticket/44296#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by jonesc@…): Replying to [comment:5 mojca@…]:

I'm not saying that this is a showstopper, but it's something I expected to fail based on problems in `root6`: {{{

...

port info root5 +python27 Error: Cannot install root5 with +python27 variant Error: Unable to open port: root6 port is already installed with +python27 and both cannot be active at once. Pick a different python variant. }}}

OK... I didn't think that was something anyone would try... I thought it more likely {{{

port info root5 port variants root5 }}}

which still work... If you really think it is needed, the same change could be made to the python variants I suppose, to move the check to a later phase... Chris -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by jonesc@…): Please commit it if you agree. Any changes to the python stuff should probably happen with the root6 port. -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by jonesc@…): It appears upstream have decided to perform a stealth update on the 5.34.19 tarball, as I have just started to see checksum errors on a few machines. No idea why, as I cannot see any obvious reason from the git commits... anyway, the patch coming next works around this in the usual way ... Grrr... Chris -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by mojca@…): One reason to do it in a different way than the FAQ suggests is because we used to put all files under {{{ /opt/local/var/macports/distfiles/root/ }}} At some point (probably with version 5.34.38), but I'm not sure when we apparently (accidentally?) switched to {{{ /opt/local/var/macports/distfiles/root5/ }}} I see no reason to continue storing files under `root5`, we should rather switch back to `root`. And if we do that, we don't have to worry about stealth updates. By comparing the two zips it looks as if windows project files had LF line endings. (I didn't inspect closely, that was just my first impression.) This is why we shouldn't need the revbump. -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X

#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by mojca@…): Committed in r121937. -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X