[MacPorts] #16964: Updated swi-prolog-devel portfile for version 5.7.2
#16964: Updated swi-prolog-devel portfile for version 5.7.2 --------------------------------+------------------------------------------- Reporter: pmoura@logtalk.org | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: | Port: --------------------------------+------------------------------------------- Updated swi-prolog-devel portfile for version 5.7.2 -- Ticket URL: <http://trac.macports.org/ticket/16964> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@logtalk.org | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Changes (by blb@macports.org): * port: => swi-prolog-devel Comment: Some issues/questions: - you don't need to increase epoch unless port thinks the new version is not later than the old - this is still the development version right (description is being changed to say stable)? - is the person being added to comaintain (who I notice is already there for swi-prolog and swi-prolog-lite) okay with being added here? - can you split the update into a non-functional patch (eg, whitespace and other things which don't affect the install) and the version increase; otherwise it makes it difficult to see what functional changes have been made Thanks -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@logtalk.org | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Comment(by pmoura@logtalk.org): Replying to [comment:1 blb@…]:
Some issues/questions:
- you don't need to increase epoch unless port thinks the new version is not later than the old - this is still the development version right (description is being changed to say stable)?
Correct.
- is the person being added to comaintain (who I notice is already there for swi-prolog and swi-prolog-lite) okay with being added here?
Jan is the author of SWI-Prolog.
- can you split the update into a non-functional patch (eg, whitespace and other things which don't affect the install) and the version increase; otherwise it makes it difficult to see what functional changes have been made
As the existing portfile is too old, I'm going to attach to this ticket the full portfile for 2.7.2. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 --------------------------------+------------------------------------------- Reporter: pmoura@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: | Port: swi-prolog-devel --------------------------------+------------------------------------------- Comment(by pmoura@…): Updated the portfile for version 5.7.3. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 --------------------------------+------------------------------------------- Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: | Port: swi-prolog-devel --------------------------------+------------------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (removed) * owner: macports-tickets@… => ryandesign@… * status: new => assigned -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 --------------------------------+------------------------------------------- Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: | Port: swi-prolog-devel --------------------------------+------------------------------------------- Comment(by ryandesign@…): I tested your new Portfile for 5.7.3 and it builds for me, so I'll commit it, with these changes: * I'll keep the description as is, to say it's the development version, instead of changing it to say it's the stable version which it isn't * I'll fix the livecheck to check for development versions, not stable versions I'll commit it in several revisions to try to separate the logical changes. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 --------------------------------+------------------------------------------- Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: | Port: swi-prolog-devel --------------------------------+------------------------------------------- Comment(by pmoura@…): Replying to [comment:5 ryandesign@…]:
I tested your new Portfile for 5.7.3 and it builds for me, so I'll commit it, with these changes:
* I'll keep the description as is, to say it's the development version, instead of changing it to say it's the stable version which it isn't * I'll fix the livecheck to check for development versions, not stable versions
Oops! The live check should be: livecheck.check regexm livecheck.url ${homepage}dl-beta.html livecheck.regex "Gzipped tar file holding the sources for BETA version <b>(\\d+\\.\\d+\\.\\d+)" I'm going to upload the corrected portfile. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: I already fixed it before I saw your new portfile. Here are the changes I committed: * r42969: Marked +st and +mt as conflicting and added descriptions. * r42970: Fixed livecheck. * r42971: Use port:-style dependencies. * r42972: Whitespace changes only. * r42974: Updated maintainers. * r42975: More whitespace changes I forgot before. * r42976: Updated to 5.7.3. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Comment(by pmoura@…): Thanks for your help in improving and committing the portfile. The only problem is your change to the maintainers. You replaced: maintainers wielemakATscience.uva.nl pmouraATlogtalk.org by maintainers pmouraATmac.com Please change it to: maintainers J.WielemakerATuva.nl pmouraATlogtalk.org Jan Wielemaker is the developer of SWI-Prolog and co-author of the original portfile (which we uses to build the PowerPC installer). As for me, I do not use my .Mac address for my SWI-Prolog collaborations. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Comment(by ryandesign@…): As indicated above, I changed the maintainers line ''from'' "pmouraATmac.com" (as it has been since swi-prolog-devel was initially created in r9569) ''to'' "wielemakATscience.uva.nl pmouraATlogtalk.org" in r42974, as you requested in [attachment:Portfile your new portfile]. I will be happy to change Jan's address from "wielemakATscience.uva.nl" to "J.WielemakerATuva.nl". If that's desired, I assume I should change it uniformly, in swi-prolog, swi-prolog-devel and swi-prolog-lite? -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Comment(by pmoura@…): Thanks. Sorry for the trouble. Please also change the Jan address to J.WielemakerATuva.nl (this is his current address) and propagate the changes to all the SWI-Prolog portfiles. -- Ticket URL: <http://trac.macports.org/ticket/16964#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16964: Updated swi-prolog-devel portfile for version 5.7.2 ---------------------------------+------------------------------------------ Reporter: pmoura@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: swi-prolog-devel | ---------------------------------+------------------------------------------ Comment(by ryandesign@…): Replying to [comment:10 pmoura@…]:
Thanks. Sorry for the trouble. Please also change the Jan address to J.WielemakerATuva.nl (this is his current address) and propagate the changes to all the SWI-Prolog portfiles. Ok, I changed it in r42981.
-- Ticket URL: <http://trac.macports.org/ticket/16964#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts