[MacPorts] #25779: Update proposal of qiv to version 2.2.3
#25779: Update proposal of qiv to version 2.2.3 ----------------------------------+----------------------------------------- Reporter: macosx12345@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qiv ----------------------------------+----------------------------------------- Please find attached a patch to the Portfile of qiv to move to the upstream version 2.2.3 (including the new maintainer's website and a livecheck feature) and an updated patch. -- Ticket URL: <http://trac.macports.org/ticket/25779> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: Update proposal of qiv to version 2.2.3 ----------------------------------+----------------------------------------- Reporter: macosx12345@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qiv ----------------------------------+----------------------------------------- Changes (by ryandesign@…): * cc: lloyd@… (added) Comment: Cc'ing maintainer for evaluation. Note your patchfile has a small mistake: "/opt/local" should go back to being "@PREFIX@" like it is in the current patchfile. -- Ticket URL: <http://trac.macports.org/ticket/25779#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: Update proposal of qiv to version 2.2.3 ----------------------------------+----------------------------------------- Reporter: macosx12345@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qiv ----------------------------------+----------------------------------------- Comment(by ryandesign@…): Note also the line "distfiles ${name}-${version}.tgz" should be deleted and replaced with the simpler "extract.suffix .tgz" -- Ticket URL: <http://trac.macports.org/ticket/25779#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: Update proposal of qiv to version 2.2.3 ----------------------------------+----------------------------------------- Reporter: macosx12345@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: | Port: qiv ----------------------------------+----------------------------------------- Comment(by macosx12345@…): Thank you for your corrections. I'm attaching a new patch to the Portfile and a new patch file to take them into account and to provide the `libmagic` variant (instead of completely switching off the use of libmagic, now the Portfile has it as an option). With this variant, qiv is able to correctly display (at least part of) the image files that miss a correct extension but that `file` is able to recognize. I tested qiv with and without the variant on Mac OS X 10.5.8 . To do, maybe: copy `qiv-command.example` into `/opt/local/share/doc/qiv` (and create that directory) or install a default `qiv-command` into `/opt/local/bin`. But anyway the installation process outputs a comment on this file. -- Ticket URL: <http://trac.macports.org/ticket/25779#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 ----------------------------------+----------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: haspatch | Port: qiv ----------------------------------+----------------------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * keywords: => haspatch * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: fixed | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Since the maintainer has not responded, I committed a version of your patch in r77387 and r77388. You mentioned having attached a new version that had a libmagic variant, but the files attached here don't seem to have that. Instead, I just left magic support enabled all the time. -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Changes (by dwhit@…): * status: closed => reopened * resolution: fixed => Comment: The new version of the port now has an undeclared dependency on gtk2. Attempts to install without first installing gtk2 fail. -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Comment(by macosx12345@…): I'm terribly sorry, it seems I forgot in last August to attach the patch with the libmagic variant, which incidentally also declared the dependency on gtk2. Here it is now. I ckeched that the current version of qiv is still 2.2.3, so the patch is not outdated. -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Comment(by ryandesign@…): It would be more helpful if you could supply a patch against the current version of the portfile in the repository, which has already been updated to 2.2.3. -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Comment(by macosx12345@…): Here it is. Thank you! -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Comment(by ryandesign@…): Why do we want to add a libmagic variant? Why not just enable this functionality all the time, as the port currently does? -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Comment(by macosx12345@…): I think this was to allow one to tune the behaviour; the default variant would make the package minimal (add a dependence against the 'file' port only if needed) and the libmagic variant would add the functionality. But we can enable it all the time or add a variant "without-libmagic". I attach a patch to the repository Portfile to add the gtk2 dependence (leaving libmagic always on). -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25779: qiv: update to version 2.2.3 -----------------------------------+---------------------------------------- Reporter: macosx12345@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: fixed | Keywords: haspatch Port: qiv | -----------------------------------+---------------------------------------- Changes (by ryandesign@…): * status: reopened => closed * cc: dwhit@… (added) * resolution: => fixed Comment: I added the gtk2 dependency in r77785. I'll leave magic support always on, since the file dependency is not large and takes less than a minute to build. -- Ticket URL: <https://trac.macports.org/ticket/25779#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts