[MacPorts] #48995: bob @ 1.2.2 Version obsolete
#48995: bob @ 1.2.2 Version obsolete -------------------------------+-------------------------------- Reporter: tiagofrepereira@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: -------------------------------+-------------------------------- Hi, Follow attached a new port file for the port bob@1.2.2. This port is now obsolete and will be replaced by py-bob. The ticket #48994 is open for that. Could you please replace it? Thanks in advance Tiago -- Ticket URL: <https://trac.macports.org/ticket/48995> MacPorts <https://www.macports.org/> Ports system for OS X
#48995: bob @ 1.2.2 Version obsolete --------------------------------+-------------------------------- Reporter: tiagofrepereira@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: bob | --------------------------------+-------------------------------- Changes (by ryandesign@…): * keywords: => haspatch * port: => bob Comment: Instead of attaching a zip file containing a complete portfile, please submit a unified diff of the portfile. This makes it easier to review your proposed changes. You've declared that bob should be replaced by py-bob. This is not correct, because py-bob is a stub port (as are all ports whose names begin with "py-") -- it doesn't install anything. Instead, you should declare that one of py-bob's subports is the replacement port, for example py27-bob. You're still defining a variable called soversion, though it is never used. It should be removed. You're declaring a pre-configure block to print an error message. You're also including the obsolete 1.0 portgroup. One of the things that portgroup does for you is to print that error message; you should not manually declare a pre-configure block to do that. Proper use of the obsolete 1.0 portgroup requires you to declare the "replaced_by ..." line before the "PortGroup obsolete 1.0" line. When filing a ticket, remember to fill in the Port field, and include the keyword "haspatch" when you are providing the fix for the issue. -- Ticket URL: <https://trac.macports.org/ticket/48995#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48995: bob @ 1.2.2 Version obsolete --------------------------------+-------------------------------- Reporter: tiagofrepereira@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: bob | --------------------------------+-------------------------------- Comment (by tiagofrepereira@…): Hi, Thanks for the comments. I just attached the diff file following your instructions. Thanks in advance Tiago -- Ticket URL: <https://trac.macports.org/ticket/48995#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48995: bob @ 1.2.2 Version obsolete --------------------------------+--------------------------- Reporter: tiagofrepereira@… | Owner: andre.anjos@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: bob | --------------------------------+--------------------------- Changes (by mf2k@…): * owner: macports-tickets@… => andre.anjos@… * cc: andre.anjos@… (removed) * cc: laurent.el-shafey@… (added) * version: 2.3.3 => * type: update => enhancement -- Ticket URL: <https://trac.macports.org/ticket/48995#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48995: bob @ 1.2.2 Version obsolete --------------------------------+--------------------------- Reporter: tiagofrepereira@… | Owner: andre.anjos@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: bob | --------------------------------+--------------------------- Changes (by devans@…): * status: new => closed * resolution: => fixed Comment: Committed with some cleanups in r142986. Correctly updates bob to py27-bob in testing. -- Ticket URL: <https://trac.macports.org/ticket/48995#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts