[MacPorts] #52309: ipcalc: use perl 5.24
#52309: ipcalc: use perl 5.24 ---------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: ipcalc ---------------------------+-------------------------------- Changes for ipcalc port: * Use perl5 PortGroup and perl 5.24 * use sha256, drop md5 and sha1 * Consistent tabulation -- Ticket URL: <https://trac.macports.org/ticket/52309> MacPorts <https://www.macports.org/> Ports system for macOS
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by devans@…): To make it easier to see what's being changed, it's usually preferable to split an update like this into two separate patches/commits. First a patch to deal with the tabulation issue and then a second to make the other changes. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:1> MacPorts <https://www.macports.org/> Ports system for macOS
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by xeron.oskom@…): @devans ok. Thank you. Uploading 2 separate patches. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:2> MacPorts <https://www.macports.org/> Ports system for macOS
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by mf2k@…): Some comments: - Do you mean to remove the line: {{{supported_archs noarch}}}? - The line: {{{depends_lib port:perl${perl5.major}}}} can be removed because the perl5 portgroup already adds it. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:3> MacPorts <https://www.macports.org/> Ports system for macOS
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by xeron.oskom@…): @mf2k thank you for comments, I returned `supported_archs`. I did not remove `depends_lib` since `port dependents perl5.24` doesn't show `ipcalc` w/o it so I'm not sure it could be removed. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:4> MacPorts <https://www.macports.org/> Ports system for macOS
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by mf2k@…): I see. It must be the {{{perl5.setup}}} command that actually sets that dependency, but you are not using that. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:5> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by xeron.oskom@…): @mf2k I think I'll keep this variant with `depends_lib`. I only use perlgroup to get `perl5.major` variable and looks like `perl5.setup` is mostly used for perl modules to set `${distfile}` and `${version}` which I don't here. -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:6> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Changes (by mf2k@…): * status: new => closed * version: 2.3.4 => * resolution: => fixed Comment: r153291 -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:7> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52309: ipcalc: use perl 5.24 ----------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: ipcalc | ----------------------------+-------------------------------- Comment (by xeron.oskom@…): Thank you! -- Ticket URL: <https://trac.macports.org/ticket/52309#comment:8> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
participants (1)
-
MacPorts