[MacPorts] #48977: oinkmaster 2.0
#48977: oinkmaster 2.0 ----------------------------+-------------------------------- Reporter: mschamschula@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: oinkmaster ----------------------------+-------------------------------- Oinkmaster is a perl script that will help you update and manage your Snort rules. It is also used to configure suricata, see #42858 -- Ticket URL: <https://trac.macports.org/ticket/48977> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------------- Reporter: mschamschula@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------------- Changes (by mf2k@…): * keywords: haspatch => * version: 2.3.3 => -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: Your portfile references a patchfile patch-oinkmaster.pl.diff. Could you attach that too? Please add a comment to the ticket when you do, so I know to check back. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by mschamschula@…): Sorry, Ryan. I'm not sure why I didn't upload the patch in the first place. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by ryandesign@…): No problem; it's easy to forget. The patch hardcodes the prefix "/opt/local". We must instead arrange to use the user's MacPorts prefix, which might be different. I'll work on this and commit it shortly. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by ryandesign@…): The port installs oinkmaster.conf. But the user is expected to edit that file, aren't they? If so, it should not be registered to the port. PortfileRecipes#configfiles -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by ryandesign@…): I attached a revised portfile and patches. In the portfile, I indicated that the port installs no architecture-specific files. I modified the master_sites to avoid redirects (wiki:howto/AvoidRedirects). I installed the documentation files (PortfileRecipes#doc). I added to your patch to change the file's encoding from ISO8859-1 to UTF-8 both so that reinplace wouldn't fail and so that running "oinkmaster.pl -V" on the command line doesn't produce incorrect output. I installed the conf file as a sample and copied it in post-activate if it's not already there. I added a patch for the manpage so that the default conf file location is correct there. To do: the sample conf file includes a path directive. Should we patch the MacPorts prefix into that? {{{ # The PATH to use during execution. If you prefer to use external # binaries (i.e. use_external_bins=1, see below), tar and gzip must be # found, and also wget if downloading via ftp, http or https. All with # optional .exe suffix. If you're on Cygwin, make sure that the path # contains the Cygwin binaries and not the native Win32 binaries or # you will get problems. # Assume UNIX style by default: path = /bin:/usr/bin:/usr/local/bin }}} A related question is whether we should set use_external_bins to 0 or 1, and either way, if we should add the dependencies it's going to use. If it's going to use wget at runtime, for example, we should add a dependency on that, since wget is not part of OS X. {{{ # We normally use external binaries (wget, tar and gzip) since they're # already available on most systems and do a good job. If you have the # Perl modules Archive::Tar, IO::Zlib and LWP::UserAgent, you can use # those instead if you like. You can set use_external_bins below to # choose which method you prefer. It's set to 0 by default on Win32 # (i.e. use Perl modules), and 1 on other systems (i.e. use external # binaries). The reason for that is that the required Perl modules # are included on Windows/ActivePerl 5.8.1+, so it's easier to use # those than to install the ported Unix tools. (Note that if you're # using scp to download the archive, external scp binary is still # used.) # use_external_bins = 0 }}} -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by mschamschula@…): Yup. That path might need to be updated. Note, however, it works as is. Now as to the wget runtime dependency - that's one thing that trace mode does not find. Please add that! -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by ryandesign@…): But if it's going to look for a wget binary at runtime, it's not going to find it in /bin:/usr/bin:/usr/local/bin. We would need to add the MacPorts path to that for a MacPorts copy of wget to be found. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Comment (by mschamschula@…): Strange, I suppose it was found on my machine via the PATH of the bash shell. Adding /opt/local/bin does no harm. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#48977: oinkmaster 2.0 -----------------------------+-------------------------- Reporter: mschamschula@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: oinkmaster | -----------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Ok, port added in r141071. -- Ticket URL: <https://trac.macports.org/ticket/48977#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts