[MacPorts] #29658: phpstylist should use MacPorts PHP
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- phpstylist uses the Mac OS X version of PHP The patch file (see Revision 79013, 314 bytes (checked in by ryandesign@…, 30 hours ago) adds {{{#!/usr/bin/php}}} [[BR]] to the code. Wouldn't it be more in keeping with MacPorts to make that {{{#!/usr/bin/env php}}} -- Ticket URL: <https://trac.macports.org/ticket/29658> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => rudloff@… * cc: ryandesign@… (added) Comment: I thought about that. On the other hand, it apparently works with Mac OS X's version of PHP. Would bringing MacPorts PHP with all its dependencies add any value to phpstylist? -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Comment(by rudloff@…): phpStylist requires PHP 4.4.2, so it works perfectly with ''/usr/bin/php'' (4.4.9).[[BR]] Installing the php port and all its dependencies seems like overkill for such a small utility. -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Comment(by face@…): fine by me - just noticed it and wondered why. Seems odd that "installing the php port" would be overkill. Macports to get a php styling utility, but only using the Apple version of php. -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Comment(by rudloff@…): Is there a way to use the port if it is installed and the Mac OS version if not ? -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Comment(by ryandesign@…): Yes; the proposal in the ticket description would do that (i.e. just change "#!/usr/bin/php" in the script to "#!/usr/bin/env php" without adding any dependency). Would that be beneficial? I'm worried it would introduce greater uncertainty. Currently, there are three possible PHP versions phpstylist in MacPorts might use: those provided by Snow Leopard, Leopard, and Tiger. If we let it use the php5 port, that makes two additional possible versions: those provided by php5 and php5-devel. Indeed, the greatest consistency can be had by requiring the use of MacPorts PHP, as is our usual policy, but I agree it is a heavy dependency, especially since by default it would bring apache2 with it. -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29658: phpstylist should use MacPorts PHP ----------------------------------+----------------------------------------- Reporter: face@… | Owner: rudloff@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: phpstylist ----------------------------------+----------------------------------------- Comment(by rudloff@…): phpStylist is not a very complex program and the readme says it has been tested with PHP from 4.4.2 to 5.2.2. I don't think letting people use a different version of PHP will cause problems. But if someone finds a problem with PHP 5.3, I don't mind writing a patch.[[BR]] [[BR]] However, I totally understand if you want to add the php port as a dependency. -- Ticket URL: <https://trac.macports.org/ticket/29658#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts