[MacPorts] #25257: libmcs: fix library install_name and versions
#25257: libmcs: fix library install_name and versions -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Keywords: | Port: libmcs -------------------------------------+-------------------------------------- This patch fixes libmcs.dylib's install_name, compatibility version and current version. Before this patch: {{{ $ otool -L /opt/local/lib/libmcs.dylib /opt/local/lib/libmcs.dylib: libmcs.dylib (compatibility version 0.0.0, current version 0.0.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1) /opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0) }}} After this patch: {{{ $ otool -L /opt/local/lib/libmcs.dylib /opt/local/lib/libmcs.dylib: /opt/local/lib/libmcs.dylib (compatibility version 1.0.0, current version 1.0.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1) /opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0) }}} This patch includes a few changes from upstream: * [https://webkeks.org/hg/buildsys/rev/8bd55aa046bd Include the library version in the resulting .dylib.] * [https://webkeks.org/hg/buildsys/rev/d8962c219f95 No need for -flat_namespace and -undefined dynamic_lookup is better.] It also undoes part of this upstream change: * [https://webkeks.org/hg/buildsys/rev/f3c803824649 Don't use -install_name anymore, it's better to use rpath instead.] I don't understand that change. I don't know what -rpath is all about. And we don't have any ports that depend on libmcs to see if they work properly without my patch. But it seems to me that without -install_name, the library's install_name is not correct. So I brought that part back. -- Ticket URL: <http://trac.macports.org/ticket/25257> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25257: libmcs: fix library install_name and versions -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Keywords: | Port: libmcs -------------------------------------+-------------------------------------- Comment(by jdunn@…): audacious media player http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile. Otherwise im not sure. -- Ticket URL: <http://trac.macports.org/ticket/25257#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25257: libmcs: fix library install_name and versions -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Keywords: | Port: libmcs -------------------------------------+-------------------------------------- Comment(by ryandesign@…): I meant to add these notes: Replying to [ticket:25257 ryandesign@…]:
This patch fixes libmcs.dylib's install_name
This patch assumes the patch from #25256 has already been applied.
* [https://webkeks.org/hg/buildsys/rev/8bd55aa046bd Include the library version in the resulting .dylib.]
This seems like a good idea to add.
* [https://webkeks.org/hg/buildsys/rev/d8962c219f95 No need for -flat_namespace and -undefined dynamic_lookup is better.]
I don't totally understand these changes but I suppose they may as well be added. -- Ticket URL: <http://trac.macports.org/ticket/25257#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25257: libmcs: fix library install_name and versions -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Keywords: | Port: libmcs -------------------------------------+-------------------------------------- Comment(by ryandesign@…): Replying to [comment:1 jdunn@…]:
audacious media player http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile.
Could you submit your attempted portfile in a new ticket? Maybe I can have a look and make it work. -- Ticket URL: <http://trac.macports.org/ticket/25257#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25257: libmcs: fix library install_name and versions -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Keywords: | Port: libmcs -------------------------------------+-------------------------------------- Comment(by jdunn@…): the patch seems to work great. -- Ticket URL: <http://trac.macports.org/ticket/25257#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25257: libmcs: fix library install_name and versions --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: jdunn@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.0 Resolution: fixed | Keywords: Port: libmcs | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Ok, it's committed in r68832. -- Ticket URL: <http://trac.macports.org/ticket/25257#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts