#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------------- Reporter: yangx59@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-molmod | -------------------------+-------------------------------- Changes (by mf2k@…): * keywords: Molmod => * version: 2.3.3 => * port: molmod => py-molmod -- Ticket URL: <https://trac.macports.org/ticket/47866#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------------- Reporter: yangx59@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-molmod | -------------------------+-------------------------------- Comment (by yangx59@…): Replying to [comment:2 mf2k@…]:

Is this really a python module? Or is it software that requires python? If the latter, then remove the python portgroup, call it molmod and depend on python27 and py27-numpy, etc.

This is a python module. -- Ticket URL: <https://trac.macports.org/ticket/47866#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------------- Reporter: yangx59@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-molmod | -------------------------+-------------------------------- Comment (by yangx59@…): Replying to [comment:4 mf2k@…]:

OK. Then that is good.

Since you are downloading from github, it would be best to utilize the github portgroup which will greatly simplify fetching the source code.

Just updated my Portfile. Add github and relative settings. -- Ticket URL: <https://trac.macports.org/ticket/47866#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------- Reporter: yangx59@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: py-molmod | -------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r136822 with these changes: * removed `python.default_version 27` because that is the default * moved the `github.setup` line above the `name` line and removed the redundant `version` line * moved the `compilers.setup` line inside the subport conditional, so that the compiler variants don't get made available in the stub port where they don't belong * removed custom livecheck since the github portgroup's default works fine * corrected typos in descriptions * removed trailing whitespace I am curious how you arrived at your selection of compiler variant exclusions. You've excluded gcc 4.5 through 4.9 inclusive, leaving gcc 4.4, 5, and 6 variants (and also the non-gcc variants). -- Ticket URL: <https://trac.macports.org/ticket/47866#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------- Reporter: yangx59@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: py-molmod | -------------------------+-------------------------- Comment (by yangx59@…): Replying to [comment:8 ryandesign@…]:

Replying to [comment:7 ryandesign@…]:

...

I am curious how you arrived at your selection of compiler variant exclusions. You've excluded gcc 4.5 through 4.9 inclusive, leaving gcc 4.4, 5, and 6 variants (and also the non-gcc variants).

The more important question is why compiler variants are being offered at all, since the port builds file without them. On their website, the compiler is added into compilers.

-- Ticket URL: <https://trac.macports.org/ticket/47866#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------- Reporter: yangx59@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: py-molmod | -------------------------+-------------------------- Comment (by yangx59@…): Replying to [comment:10 ryandesign@…]:

Replying to [comment:9 yangx59@…]:

...

On their website, the compiler is added into compilers.

I don't think I understand what you mean.

If not necessary, we could erase those setting about gcc. I mean on their website, gcc is recommended, especially gcc >=4.5 versions. -- Ticket URL: <https://trac.macports.org/ticket/47866#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X

#47866: py27-molmod @1.1 New Port submission -------------------------+-------------------------- Reporter: yangx59@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: py-molmod | -------------------------+-------------------------- Comment (by yangx59@…): Replying to [comment:12 ryandesign@…]:

Then why did you ''exclude'' gcc 4.5 through 4.9 inclusive in your portfile?

And as I said, it builds fine with the default compiler, clang.

Recommendations to use gcc, made by projects that are not specifically considering OS X in that recommendation, should usually be ignored.

Since it sounds like there was some misunderstanding here, I removed the compiler variants in r136824. If it still works, it's fine. Thank you.

-- Ticket URL: <https://trac.macports.org/ticket/47866#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X