[MacPorts] #37828: webkit-gtk: error: "class JSC::ListableHandler<JSC::WeakReferenceHarvester>::List" is private
#37828: webkit-gtk: error: "class JSC::ListableHandler<JSC::WeakReferenceHarvester>::List" is private --------------------------+-------------------------------- Reporter: ryandesign@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: tiger | Port: webkit-gtk --------------------------+-------------------------------- Building webkit-gtk @1.10.2 fails on Tiger ppc with: {{{ In file included from ./Source/JavaScriptCore/config.h:30, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26: ./Source/WTF/wtf/Platform.h:710:22: warning: "__MAC_OS_X_VERSION_MIN_REQUIRED" is not defined ./Source/JavaScriptCore/heap/ListableHandler.h:58: error: ?class JSC::ListableHandler<JSC::WeakReferenceHarvester>::List? is private ./Source/JavaScriptCore/heap/GCThreadSharedData.h:78: error: within this context ./Source/JavaScriptCore/heap/ListableHandler.h:58: error: ?class JSC::ListableHandler<JSC::UnconditionalFinalizer>::List? is private ./Source/JavaScriptCore/heap/GCThreadSharedData.h:79: error: within this context }}} -- Ticket URL: <https://trac.macports.org/ticket/37828> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: error: "class JSC::ListableHandler<JSC::WeakReferenceHarvester>::List" is private ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Changes (by ryandesign@…): * cc: devans@… (added) * owner: macports-tickets@… => jeremyhu@… -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by jeremyhu@…): __MAC_OS_X_VERSION_MIN_REQUIRED is set by AvailabilityInternal.h, which isn't on Tiger. Try adding this and trying again: {{{ configure.cppflags-append -D__MAC_OS_X_VERSION_MIN_REQUIRED=1040 }}} -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by ryandesign@…): Replying to [comment:2 jeremyhu@…]:
{{{ configure.cppflags-append -D__MAC_OS_X_VERSION_MIN_REQUIRED=1040 }}}
That gets rid of the warning, but the errors shown in the description remain. The errors look similar to ones we had with an old version of harfbuzz: http://lists.freedesktop.org/archives/harfbuzz/2012-October/002592.html [[br]] To "fix" it they just marked the members as non-private: http://cgit.freedesktop.org/harfbuzz/commit/?id=365f27ab5ba025bf1be6a882ed21... -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by jeremyhu@…): I pushed the __MAC_OS_X_VERSION_MIN_REQUIRED change. Can you try a patch marking JSC::ListableHandler<*>::List as a public class? Also, would you mind testing webkit-gtk-1.11.4: {{{ git clone git://github.com/jeremyhu/dports_jeremyhu.git cd dports_jeremyhu portindex }}} Then just add file:///path/to/dports_jeremyhu to /opt/local/etc/macports/sources.conf -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by ryandesign@…): Replying to [comment:4 jeremyhu@…]:
Can you try a patch marking `JSC::ListableHandler<*>::List` as a public class?
I've tried the patch I've attached here now. It got me further (#37882). -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by ryandesign@…): Replying to [comment:4 jeremyhu@…]:
Also, would you mind testing webkit-gtk-1.11.4:
It depends on harfbuzz which depends on graphite2 which does not build on Tiger because of an unrecognized compiler flag and I don't know what the flag is supposed to do or whether I can just remove it or what: https://sourceforge.net/tracker/?func=detail&aid=3597386&group_id=66144&atid... -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by ryandesign@…): (And I'd love to get that graphite2 issue fixed because it's the last issue I know of preventing updating MacPorts pango to 1.32.5) -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Changes (by jeremyhu@…): * status: new => closed * resolution: => fixed Comment: r102364 for this particular issue. -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by jeremyhu@…): Just remove -fno-stack-protecto from CFLAGS on Tiger and you should be fine. -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37828: webkit-gtk: __MAC_OS_X_VERSION_MIN_REQUIRED is not defined ---------------------------+------------------------ Reporter: ryandesign@… | Owner: jeremyhu@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: tiger Port: webkit-gtk | ---------------------------+------------------------ Comment (by jeremyhu@…): r102365 for graphite2. -- Ticket URL: <https://trac.macports.org/ticket/37828#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts