#30664: bash-completion: document to source $prefix/etc/profile.d/ --------------------------------+------------------------------------------- Reporter: blair@… | Owner: raimue@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Keywords: | Port: bash-completion --------------------------------+------------------------------------------- Changes (by macsforever2000@…): * owner: macports-tickets@… => raimue@… -- Ticket URL: <https://trac.macports.org/ticket/30664#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#30664: bash-completion: document to source $prefix/etc/profile.d/ ---------------------------------+------------------------------------------ Reporter: blair@… | Owner: raimue@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Resolution: | Keywords: Port: bash-completion | ---------------------------------+------------------------------------------ Changes (by raimue@…): * status: closed => reopened * resolution: fixed => Comment: Sorry, I wasn't able to respond in time as I am on travel. I don't see how this is related to bash-completion in any way? Please add a note to maven instead if it needs to source any stuff to work. Any port needs to install it's bash-completion related files into `${prefix}/etc/bash_completion.d`. It is a failure in these ports, not in bash-completion. If the directory `etc/profile.d` contains unrelated files, it will do more than just enabling bash-completion. This is not the behavior users would expect and therefore this is dangerous. -- Ticket URL: <https://trac.macports.org/ticket/30664#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#30664: bash-completion: document to source $prefix/etc/profile.d/ ---------------------------------+------------------------------------------ Reporter: blair@… | Owner: raimue@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Resolution: | Keywords: Port: bash-completion | ---------------------------------+------------------------------------------ Comment(by raimue@…): If you source everything in `${prefix}/etc/profile.d` it's your responsibility to ensure that things will not be sourced multiple times. MacPorts does not use `${prefix}/etc/profile.d`, instead ports usually create wrappers which set the required environment variables. For an example, see the wine port. If we always want to source `${prefix}/etc/profile.d`, we would need different installation instructions. If maven needs some special environment, it is a bug in maven. Add a note to maven that it needs special environment. The note in the bash-completion port should tell people how to enable bash-completion. It should not tell how to source all things which have been dropped into `${prefix}/etc/profile.d`. Files there might do stuff which is unrelated to bash-completion. Let's say it's not '''dangerous''', but unexpected behavior if the instructions for bash-completion influence other tools. -- Ticket URL: <https://trac.macports.org/ticket/30664#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS

#30664: bash-completion: document to source $prefix/etc/profile.d/ ------------------------------------+--------------------------------------- Reporter: blair@… | Owner: raimue@… Type: enhancement | Status: reopened Priority: Normal | Milestone: Component: ports | Version: 2.0.1 Resolution: | Keywords: Port: bash-completion maven | ------------------------------------+--------------------------------------- Comment(by blair@…): Yes, we need to watch out that you don't source things in ${prefix}/etc/profile.d twice. My concern is that with the instructions to source /$prefix/etc/bash_completion and if/when we have people source in ${prefix}/etc/profile.d will cause a double source of bash-completion. -- Ticket URL: <https://trac.macports.org/ticket/30664#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS