[MacPorts] #38798: Gnuplot demo folder and documentation missing
#38798: Gnuplot demo folder and documentation missing -----------------------+-------------------------------- Reporter: pwolter@… | Owner: macports-tickets@… Type: defect | Status: new Priority: High | Milestone: Component: ports | Version: 2.1.3 Keywords: gnuplot | Port: gnuplot -----------------------+-------------------------------- The gnuplot package is not complete. The demo files are completely missing. Moreover, if you "manually" download them and try them out as outlined in http://www.gnuplot.info/screenshots/index.html#demos you get just errors. Even if you install/copy the 4.6 examples from sourceforge. -- Ticket URL: <https://trac.macports.org/ticket/38798> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Changes (by larryv@…): * keywords: gnuplot => * owner: macports-tickets@… => mojca@… * priority: High => Normal Comment: Thanks for the ticket. In the future, please Cc relevant port maintainers and do not set the Priority field. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by mojca@…): I can difinitely add demo files when I upload version 4.6.3. The only question is where. However, if you want to get the errors fixed, you need to point out what errors you get exactly. If these are font-related, you might have to install some font to run the demos. It might be a version-mismatch: some feature that has only been introduced in 4.7 and doesn't work in 4.6 yet for example. It might be a broken terminal (non-working library or some mac-specific problem). If it's a different problem, I suggest to report the problem upstream. Broken demo is not something that a packager can solve. (Broken terminal might be.) -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by mojca@…): I figured out that demos contain a bunch of files that shouldn't be installed/copied, like "Makefile", "Makefile.in" etc. If someone suggests a nice patch to copy the files, I'll add it, else I'll try to get it fixed upstream first. The problem is that I'm neither sure where the demo files should go nor am I aware of which files should not be installed. I opened a bug report: * https://sourceforge.net/p/gnuplot/bugs/1234/ and let's see what comes out of it. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by mojca@…): The upstream replied with won't-fix. MacPorts can fix this, but I need some concrete suggestions. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by mojca@…): Here's the proposed patch: {{{ --- Portfile +++ Portfile @@ -179,9 +179,15 @@ xinstall -m 0644 ${luadir}/gnuplot-lua-tikz.tex ${texmf}/tex/plain/gnuplot-lua-tikz } - xinstall -d -m 0755 ${destroot}${prefix}/share/doc/${name} - xinstall -m 0644 ${distpath}/${name}.pdf \ - ${destroot}${prefix}/share/doc/${name} + set destdocdir ${destroot}${prefix}/share/doc/${name} + xinstall -d -m 0755 ${destdocdir} + xinstall -m 0644 ${distpath}/${name}.pdf ${destdocdir} + + # copy demo files + file copy ${workpath}/${distname}/demo ${destdocdir} + foreach {makefile} {Makefile Makefile.in Makefile.am Makefile.am.in} { + delete ${destdocdir}/demo/${makefile} + } } # this temporary workaround removes files that accidentally circumvented destroot }}} I would be grateful for feedback, but as it requires a revision bump and is not urgent, I suggest to wait for the next opportunity when either version or revision will change. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by macsforever2000@…): @mojca: Please always attach patches to a ticket instead of pasting inline. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: gnuplot | ------------------------+--------------------- Comment (by mojca@…): Here it is. (I'm thinking of waiting for gd2 patch which will need a revbump anyway, this could be patched just before/after that.) -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#38798: Gnuplot demo folder and documentation missing ------------------------+--------------------- Reporter: pwolter@… | Owner: mojca@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: fixed | Keywords: Port: gnuplot | ------------------------+--------------------- Changes (by mojca@…): * status: new => closed * resolution: => fixed Comment: Fixed in r108795. -- Ticket URL: <https://trac.macports.org/ticket/38798#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts