[MacPorts] #29901: libmilter +universal
#29901: libmilter +universal ----------------------------------+----------------------------------------- Reporter: pixilla@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: libmilter ----------------------------------+----------------------------------------- Have libmilter build universal. -- Ticket URL: <https://trac.macports.org/ticket/29901> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29901: libmilter +universal ----------------------------------+----------------------------------------- Reporter: pixilla@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: libmilter ----------------------------------+----------------------------------------- Comment(by jmr@…): Why remove `use_configure no`? Why the random whitespace removal? And shouldn't you still be doing the same thing but with configure.cc_archflags in the non-universal case? -- Ticket URL: <https://trac.macports.org/ticket/29901#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29901: libmilter +universal ----------------------------------+----------------------------------------- Reporter: pixilla@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: libmilter ----------------------------------+----------------------------------------- Comment(by pixilla@…): Replying to [comment:1 jmr@…]:
Why remove `use_configure no`? To get free +universal variant. Why the random whitespace removal? Are referring to the empty line after "PortSystem" where I had added and removed PortGroup muniversal? If not, I don't see any random whitespace removal. I did intentionally remove the "platform darwin 10" block. And shouldn't you still be doing the same thing but with configure.cc_archflags in the non-universal case? I don't know, the port did not use them before.[[BR]] [[BR]] Thank you for the feedback jmr, I have uploaded patch-Portfile.2.diff which I believe addresses each of these issues. More feedback is welcome.
-- Ticket URL: <https://trac.macports.org/ticket/29901#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29901: libmilter +universal ----------------------------------+----------------------------------------- Reporter: pixilla@… | Owner: dluke@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: libmilter ----------------------------------+----------------------------------------- Changes (by dluke@…): * owner: macports-tickets@… => dluke@… * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/29901#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29901: libmilter +universal -----------------------------------+---------------------------------------- Reporter: pixilla@… | Owner: dluke@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: haspatch Port: libmilter | -----------------------------------+---------------------------------------- Changes (by dluke@…): * status: assigned => closed * resolution: => fixed Comment: Looks good to me. Committed in r79776. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/29901#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts