#44698: py-gwpy @0.1a10 new port submission -------------------------------+-------------------------------- Reporter: duncanmmacleod@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: py-gwpy | -------------------------------+-------------------------------- Changes (by aronnax@…): * cc: ram@… (added) Comment: CCing Adam. Duncan, this Portfile looks pretty straightforward. Nice job. A few comments: * Usually the Portfiles themselves do not bear copyright statements. I'm not sure if it is a problem for MacPorts or not. The package's Python code presumably bears its own copyright statement. * Consider adding {{{openmaintainer}}} to the maintainers list so that committers are permitted to make minor changes to your port (such as updating to new versions). -- Ticket URL: <https://trac.macports.org/ticket/44698#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X

#44698: py-gwpy @0.1a10 new port submission -------------------------------+-------------------------------- Reporter: duncanmmacleod@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: py-gwpy | -------------------------------+-------------------------------- Comment (by duncanmmacleod@…): Yes, the code has its own licensing and copyright statements, I can easily remove that from the Portfile if its the standard procedure. Currently there are no other developers of the GWpy source, so I will leave the maintainer to me for now, if that makes sense. As for the version number, this is an alpha pre-release of version 0.1, hence `0.1a10`. Once I get to a stable 0.1 release, the `aX` suffix will be removed. -- Ticket URL: <https://trac.macports.org/ticket/44698#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X

#44698: py-gwpy @0.1a10 new port submission -------------------------------+-------------------------------- Reporter: duncanmmacleod@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: py-gwpy | -------------------------------+-------------------------------- Comment (by ram@…): Replying to [comment:4 duncanmmacleod@…]:

As for the version number, this is an alpha pre-release of version 0.1, hence `0.1a10`. Once I get to a stable 0.1 release, the `aX` suffix will be removed.

I believe the MacPorts version comparison algorithm will consider 0.1a10 to be newer than 0.1 so using that scheme may cause problems. What would happen if `nds2-client` and `lalframe` are already installed, but the `+nds2` and `+gwf` variants are not specified? From looking at the Portfile there is nothing to disable support for these features if the variants are not requested but the `nds2-client` and `lalframe` ports are already present. As I see it there are two ways to resolve this: 1. Make these non-optional features 1. Make sure the nds2 and gwf code is not built unless the appropriate variants are specified. -- Ticket URL: <https://trac.macports.org/ticket/44698#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X

#44698: py-gwpy @0.1a10 new port submission -------------------------------+-------------------------------- Reporter: duncanmmacleod@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: py-gwpy | -------------------------------+-------------------------------- Comment (by ram@…): Replying to [comment:7 larryv@…]:

The `epoch` could easily be incremented when the suffix is removed. The focus should be on making it clear which version of the software we are providing; if “0.1a10” is the upstream version number, then that’s the number we should use.

Yep, I just try to avoid bumping epoch whenever possible. I guess the real problem here is that we don't have a way to specify that a version is a pre-release, essentially we need something like `~` in Debian: https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version -- Ticket URL: <https://trac.macports.org/ticket/44698#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X