[MacPorts] #40635: auto-multiple-choice @1.1.1: update to 1.2.1
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 ------------------------------+---------------------------------- Reporter: Joel.Brogniart@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Keywords: | Port: auto-multiple-choice ------------------------------+---------------------------------- The patch change all lines for alignment. The author of AMC has contacted the maintainer and the maintainer tell him that he no longer has enough time to maintain the port. I could replace him and I put my address as a maintainer in the portfile. -- Ticket URL: <https://trac.macports.org/ticket/40635> MacPorts <http://www.macports.org/> Ports system for OS X
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Changes (by devans@…): * status: new => assigned * owner: macports-tickets@… => devans@… * cc: Joel.Brogniart@… (removed) Comment: The ticket reporter is automatically CC'ed it's not necessary to CC yourself in addition. -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Comment (by devans@…): Joel -- Thanks for your submission. A couple of comments: 1) It's very difficult so see what has actually been changed in your proposed patch because of the reformatting. Recommended procedure is to submit actual changes in one patch and reformatting in another to help with this problem. Have attached a revised patch that removes that white space only changes to make it more readable for now. Can add the reformatting in a subsequent patch. 2) You've declared a conflict with port auto-multiple-choice-devel but no such port currently exists. Do you plan to submit one? 3) The post-activate phase using gdk-pixbuf-query-loaders shouldn't be necessary unless this port installs a new gdk-pixbuf loader. I don't see one. 4) I would suggest that, in addition to your own name as maintainer, you add openmaintainer so that other committers can help make updates to the port when you are not available. Is that OK with you? Having said that I have tested the port and it seems to install with no problems other than what I have mentioned above. -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Comment (by Joel.Brogniart@…): 1) Sorry for the extra work I gave you. I didn't know what was the best way to keep patch and portfile simple to read. I should have asked to the list. 2) Yes, I plan to submit a developer version later. 3) The post-activate phase solve a launching failure of the application for some users. I had this problem once and haven't been able to trace the source. This command prevents the problem from recurring. I'll remove this phase so If the problem occurs again, I'll try to see with the developer to solve it in the application. 4) It is OK to add openmaintainer. -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Comment (by devans@…): Committed changes only in r111171. I removed the conflicts statement for now. You can add it back when you submit the -devel version of the port. White space changes committed in r111173. Thanks for taking maintainership of this port that has been broken for some time. -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: fixed | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Changes (by devans@…): * status: assigned => closed * resolution: => fixed -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts