[MacPorts] #43766: wcslib: fix library install_name
#43766: wcslib: fix library install_name --------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Keywords: | Port: wcslib --------------------------+-------------------- The install_name of libwcs.${version}.dylib is wrong (isn't set at build time): {{{ $ port installed wcslib The following ports are currently installed: wcslib @4.23_0 (active) $ otool -L /opt/local/lib/libwcs.4.23.dylib /opt/local/lib/libwcs.4.23.dylib: libwcs.4.23.dylib (compatibility version 4.0.0, current version 4.23.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1) }}} The port's optional gcc variants try to deal with this problem with this block: {{{ post-destroot { system "install_name_tool -change libwcs.${version}.dylib ${prefix}/lib/libwcs.${version}.dylib ${destroot}${prefix}/lib/libpgsbox.${version}.dylib" } }}} But the better way to deal with this is to set the install_name of libwcs.${version}.dylib at build time. -- Ticket URL: <https://trac.macports.org/ticket/43766> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: Port: wcslib | ---------------------------+-------------------- Comment (by john@…): The attached should address both this issue and #43765. -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: Port: wcslib | ---------------------------+-------------------- Comment (by ryandesign@…): Thanks. I was hoping there would be a variable that could be accessed from the configure script to get the library directory (`$libdir`?), to avoid having to reinplace the prefix. -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: Port: wcslib | ---------------------------+-------------------- Comment (by john@…): That better? -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: Port: wcslib | ---------------------------+-------------------- Comment (by ryandesign@…): Oh, well I looked into it too, and $libdir should be $exec_prefix/lib, which means you shouldn't need to put $prefix in front of it, but the configure script doesn't expand the variable, and $exec_prefix isn't defined in the Makefile. Really, this needs to be reported to the developers for a correct fix. -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+-------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: Port: wcslib | ---------------------------+-------------------- Comment (by john@…): Indeed, I discovered similar: I initially used `${libdir}` before realising it didn't work and using the `reinplace` you (reasonably enough) objected to above. Happy to take this to upstream, but, if my latest fix works for you, can we commit that to ensure we're shipping a working library at least in the short term? -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#43766: wcslib: fix library install_name ---------------------------+---------------------- Reporter: ryandesign@… | Owner: john@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: fixed | Keywords: haspatch Port: wcslib | ---------------------------+---------------------- Changes (by ryandesign@…): * status: new => closed * keywords: => haspatch * resolution: => fixed Comment: Committed a fix in r120292. I used a fix that didn't need `reinplace`, and also used `$SONAME` instead of `$SHRLIB`. Please do notify upstream of the problem so they can fix it properly. -- Ticket URL: <https://trac.macports.org/ticket/43766#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts