[MacPorts] #37097: DSDP should include atlas variant *option*
#37097: DSDP should include atlas variant *option* ---------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: defect | Status: new Priority: High | Milestone: Component: ports | Version: 2.1.2 Keywords: dsdp, atlas, cvxopt | Port: dsdp ---------------------------------+-------------------------------- Many people have run into issues building DSDP and other ports that depend on it (like cvxopt) due to linker issues with building against ATLAS. It is suggested that a atlas variant option is created for DSDP in order to enable default linking against the Accelerator Framework libs provided by Apple. I have tested building cvxopt with -dsdp and it -atlas, which compiles and runs without errors. -- Ticket URL: <https://trac.macports.org/ticket/37097> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37097: DSDP should include atlas variant *option* --------------------------------+--------------------- Reporter: dallas.johnston@… | Owner: mnick@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: dsdp | --------------------------------+--------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => mnick@… * priority: High => Normal * version: 2.1.2 => * type: defect => enhancement * keywords: dsdp, atlas, cvxopt => -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37097: DSDP should include atlas variant *option* --------------------------------+--------------------- Reporter: dallas.johnston@… | Owner: mnick@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: dsdp | --------------------------------+--------------------- Comment (by jjstickel@…): Also see #35851. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+---------------------- Reporter: dallas.johnston@… | Owner: mnick@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+---------------------- Changes (by ryandesign@…): * keywords: => haspatch * port: dsdp => DSDP Comment: In the future please attach a unified diff instead of a full portfile; this makes it easier to review your proposed changes. I'm attaching a diff of your changes now. Your proposed atlas variant is insufficient: it only adds a dependency on atlas, without doing anything to ensure that if atlas is already installed it will ''not'' be used unless the atlas variant is selected. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+---------------------- Reporter: dallas.johnston@… | Owner: mnick@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+---------------------- Comment (by ryandesign@…): Also, in other ports that offer the choice of ATLAS or Apple's Accelerate framework—like octave—there are two conflicting variants: atlas and accelerate; perhaps we should continue that tradition here—assuming DSDP can be made to work with today's ATLAS (#35851); if it can't, there's no point keeping an ATLAS option at all. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Changes (by macsforever2000@…): * owner: mnick@… => macports-tickets@… Comment: mnick has retired. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by jjstickel@…): Note that the atlas linking issue has now been resolved in #35851. Nonetheless, it may be worthwhile to make atlas a variant. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by jjstickel@…): The new patchfiles enable accelerate framework for LAPACK and BLAS ''by default'' (no variant selected) and provide an atlas variant. I have not tested the accelerate framework (-atlas), but the compile flags were reported to work by Mark Brethen (https://lists.macosforge.org/pipermail /macports-users/2014-July/036012.html). -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by mark.brethen@…): also see #44503 -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by jjstickel@…): Replying to [comment:10 mark.brethen@…]:
also see #44503
jjstickel: I'm curious why you placed the atlas variant inside the octave variant? Is this the only situation where you'd want/need atlas?
It's not (the way trac shows the patch makes it look that way). It is its own variant, and it triggers some action in the post-patch block. Anyway, please test the patches and report back. Thanks. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by ryandesign@…): If you're just adding a variant, which is not going to be on by default, then there is no need to increase the port's revision. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by jjstickel@…): Replying to [comment:12 ryandesign@…]:
If you're just adding a variant, which is not going to be on by default, then there is no need to increase the port's revision. I thought about whether a revision increment was necessary; I included it because the default behavior is changing from compiling with atlas to compiling with accelerate framework. But I guess forcing an upgrade on users wouldn't help them catch this change anyway.
-- Ticket URL: <https://trac.macports.org/ticket/37097#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by mark.brethen@…): Replying to [comment:11 jjstickel@…]:
Anyway, please test the patches and report back. Thanks.
Okay, whenever it's committed. -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X
#37097: DSDP should include atlas variant *option* --------------------------------+-------------------------------- Reporter: dallas.johnston@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: DSDP | --------------------------------+-------------------------------- Comment (by mark.brethen@…): It works. I uploaded another portfile patch, removing the rev change (if that's really the case). -- Ticket URL: <https://trac.macports.org/ticket/37097#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts