[MacPorts] #51625: ldas-tools being obsoleted
#51625: ldas-tools being obsoleted ------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: ldas-tools ------------------------+-------------------------------- The ldas-tools package has been obsoleted and now a collection of 7 packages. -- Ticket URL: <https://trac.macports.org/ticket/51625> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+-------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: ldas-tools | --------------------------+-------------------------------- Changes (by mf2k@…): * keywords: haspatch => * version: 2.3.4 => * type: submission => enhancement Comment: Thanks. [https://guide.macports.org/#development.patches Per the guidelines], please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Changes (by mf2k@…): * keywords: => haspatch maintainer -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ryandesign@…): Did you see my previous ticket #51609 where I requested this update? There are various suggestions in that ticket that might be helpful. For example, is it really appropriate to mark ldas-tools replaced_by ldas-tools-al? Did ldas-tools 2.4.2 only contain the files now contained in ldas-tools-al 2.5.0, or did ldas-tools 2.4.2 also contain files now contained in the other ports? If the latter, it would be more appropriate to make ldas- tools a meta port that depends on all the other ports. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ed.maros@…): Replying to [comment:3 ryandesign@…]:
Did you see my previous ticket #51609 where I requested this update? There are various suggestions in that ticket that might be helpful. For example, is it really appropriate to mark ldas-tools replaced_by ldas- tools-al? Did ldas-tools 2.4.2 only contain the files now contained in ldas-tools-al 2.5.0, or did ldas-tools 2.4.2 also contain files now contained in the other ports? If the latter, it would be more appropriate to make ldas-tools a meta port that depends on all the other ports. The original ldas-tools package originally contained all of the content of each ldas-tools-* package. I would be willing to make it a meta package, but still want the ability to install a strict subset of the ldas-tools packages also. Is that possible?
-- Ticket URL: <https://trac.macports.org/ticket/51625#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ryandesign@…): Certainly. It would just mean that users who already had ldas-tools 2.4.2 installed will be upgraded to the full set of separate ports. Did you consider using subports? It looks like there's a bit of common code between the separate portfiles you submitted; a single common set of code could be shared by using subports. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ed.maros@…): Replying to [comment:5 ryandesign@…]:
Certainly. It would just mean that users who already had ldas-tools 2.4.2 installed will be upgraded to the full set of separate ports.
Did you consider using subports? It looks like there's a bit of common code between the separate portfiles you submitted; a single common set of code could be shared by using subports.
Are there examples of Portfiles that are metapackages and projects that use subports? I would like to take the project in these directions. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ed.maros@…): I have modified the Portfile to be a meta package for the ldas-tools suite of tools. This replaces the previous Portfile which flagged the project as obsolete. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ed.maros@…): Replying to [comment:7 ed.maros@…]:
I have modified the Portfile to be a meta package for the ldas-tools suite of tools. This replaces the previous Portfile which flagged the project as obsolete.
Is there work still to be done on this Portfile before it can be accepted? -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Comment (by ram@…): Tried updating to the new ports and it failed with the following: {{{ [ram@hastur ~]$ port outdated The following installed ports are outdated: ldas-tools 2.4.2_1 < 20160622_0 [ram@hastur ~]$ sudo port upgrade outdated ---> Computing dependencies for ldas-tools-al Error: Unable to exec port: Can't install ldas-tools-al because conflicting ports are active: port:ldas-tools To report a bug, follow the instructions in the guide: http://guide.macports.org/#project.tickets [ram@hastur ~]$ }}} I added the following code to `ldas-tools-al` to deactivate `ldas-tools` during the `pre-activate` stage (and remove the conflict) and then it all seems to work: {{{ pre-activate { # ldas-tools-al now contains files that used to be provided by ldas- tools if {![catch {set installed [lindex [registry_active ldas-tools] 0]}]} { set _version [lindex $installed 1] if {[vercmp $_version 2.5.0] < 0} { # ldas-tools used to install some files now provided by ldas-tools in versions < 2.5.0 registry_deactivate_composite ldas-tools "" [list ports_nodepcheck 1] } } } }}} If there are no objections to these changes I'll incorporate this into the patch set and push the changes in the morning. -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ram@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Changes (by ram@…): * owner: macports-tickets@… => ram@… * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ram@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Changes (by ram@…): * cc: ram@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#51625: ldas-tools being obsoleted --------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ram@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: ldas-tools | --------------------------+--------------------------------- Changes (by ram@…): * status: assigned => closed * resolution: => fixed Comment: r151462 -- Ticket URL: <https://trac.macports.org/ticket/51625#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts