[MacPorts] #29693: ejabberd: use notes
#29693: ejabberd: use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: ciserlohn@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: ejabberd -------------------------------------+-------------------------------------- ejabberd has a post-install block that uses `ui_msg` commands to tell the user about the config files. It would be better to use the newer `notes` feature for this purpose. In addition, the message currently printed advises the user to ''move'' the sample configuration files. We should not be suggesting that the user should move any file installed by MacPorts. Instead we should suggest they ''copy'' the sample configuration files. The attached patch makes these changes. What do you think? Can we commit this? -- Ticket URL: <https://trac.macports.org/ticket/29693> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29693: ejabberd: use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: ciserlohn@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: ejabberd -------------------------------------+-------------------------------------- Comment(by ryandesign@…): Revised patch makes use of existing portfile variable. -- Ticket URL: <https://trac.macports.org/ticket/29693#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29693: ejabberd: use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: ciserlohn@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: ejabberd -------------------------------------+-------------------------------------- Comment(by ciserlohn@…): Replying to [comment:1 ryandesign@…]:
Revised patch makes use of existing portfile variable.
Please do apply the patches. I already thought about removing the ui_msg commands (they were already there when I took over the port), but I didn't wanted to mix this change with the version update from #29687. -- Ticket URL: <https://trac.macports.org/ticket/29693#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29693: ejabberd: use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: ciserlohn@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: ejabberd -------------------------------------+-------------------------------------- Comment(by ciserlohn@…): Replying to [comment:2 ciserlohn@…]:
Replying to [comment:1 ryandesign@…]:
Revised patch makes use of existing portfile variable.
Please do apply the patches. I meant, apply the second patch (ejabberd-notes.2.diff)
-- Ticket URL: <https://trac.macports.org/ticket/29693#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29693: ejabberd: use notes --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: ciserlohn@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: ejabberd | --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: r79209 -- Ticket URL: <https://trac.macports.org/ticket/29693#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts