[MacPorts] #37328: nethack @3.4.3 +x11 Build failure
#37328: nethack @3.4.3 +x11 Build failure ------------------------+-------------------------------- Reporter: nurblieh@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: ------------------------+-------------------------------- nethack with the x11 variant selecetd fails to build, as the X11 headers can not be found. The bug is that the build.args-appends directive in the Portfile overrides the Makefile's CFLAGS that the x11 variant patches in. Removing the build.args-apend directive from the Portfile fixes the issue and is, largely unnecessary. (O vs O2 though...) This is from the x11 Makefile patch, {{{ -CFLAGS = -O -I../include +CFLAGS = -O -I../include -I/usr/X11R6/include }}} This is what exists in build.args-append, {{{ build.args-append CFLAGS="-O2 -I../include" }}} So the {{{-I/usr/X11R6/include}}} never gets respected. Attached is a working diff. Xcode 4.4; Mac OS X 10.8.2 -- Ticket URL: <https://trac.macports.org/ticket/37328> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+-------------------------------- Reporter: nurblieh@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ryandesign@…): We don't want to use /usr/X11R6 for X11; we want to use ${prefix} for that. -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: nethack | -------------------------+--------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => yeled@… * port: => nethack -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: nethack | -------------------------+--------------------- Comment (by nurblieh@…): Ah, then potentially there is something wrong with my install or my brain. I have no X11 headers under ${prefix}. The headers do however exist under /usr/X11R6/include , which the x11 variant uses in its patch files. My understanding is that ${prefix} expands to /opt/local in most cases. The default macports install location. -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: nethack | -------------------------+--------------------- Comment (by jmr@…): Yeah, the x11 variant also needs a dependency on one or more xorg ports. -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: nethack | -------------------------+--------------------- Comment (by nurblieh@…): Replying to [comment:4 jmr@…]:
Yeah, the x11 variant also needs a dependency on one or more xorg ports.
Ah, that makes perfect sense, thanks much. With that intel, here's another patch. Tested on my install. {{{ Index: dports/games/nethack/Portfile =================================================================== --- dports/games/nethack/Portfile (revision 100595) +++ dports/games/nethack/Portfile (working copy) @@ -66,6 +66,7 @@ x11/patch-include__config.h \ x11/patch-sys__unix__Makefile.src \ x11/patch-sys__unix__Makefile.top + depends_lib-append port:xorg-libXaw } variant autopickup_exceptions { }}} -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: nethack | -------------------------+--------------------- Comment (by nurblieh@…): I should mention the above patch is stand-alone. The previously attached patch is obsolete and unnecessary. -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37328: nethack @3.4.3 +x11 Build failure -------------------------+--------------------- Reporter: nurblieh@… | Owner: yeled@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: Port: nethack | -------------------------+--------------------- Changes (by mf2k@…): * status: new => closed * resolution: => fixed Comment: r122655 -- Ticket URL: <https://trac.macports.org/ticket/37328#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts