[MacPorts] #17741: UPDATE: fox-1.6.34
#17741: UPDATE: fox-1.6.34 -----------------------------------+---------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Keywords: | Port: fox -----------------------------------+---------------------------------------- This patch updates the fox portfile to version 1.6.34. It also corrects a build-time bug related to the Freetype2 dependency. -- Ticket URL: <http://trac.macports.org/ticket/17741> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17741: UPDATE: fox-1.6.34 -----------------------------------+---------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Keywords: | Port: fox -----------------------------------+---------------------------------------- Changes (by ryandesign@…): * cc: lyle@… (removed) * cc: ryandesign@… (added) Comment: Replying to [ticket:17741 lyle@…]:
It also corrects a build-time bug related to the Freetype2 dependency.
What is the built-time bug? I see you're adding a dependency on freetype and adding `-I/${prefix}/include/freetype2` to the cppflags. (That should be `-I${prefix}/include/freetype2` by the way.) But I thought the decision in #14807 was that no change to the cppflags was necessary? On my system it links with freetype without this change. -- Ticket URL: <http://trac.macports.org/ticket/17741#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17741: UPDATE: fox-1.6.34 -----------------------------------+---------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Keywords: | Port: fox -----------------------------------+---------------------------------------- Comment(by lyle@…): Replying to [comment:1 ryandesign@…]:
What is the built-time bug? I've recently received two different bug reports that were similar to #14807 (although I had forgotten about that one). Basically, it was that the build would break when trying to compile a file which included <freetype/config/ftheader.h> because -I/${prefix}/include/freetype2 wasn't in the include path.
I see you're adding a dependency on freetype and adding `-I/${prefix}/include/freetype2` to the cppflags... but I thought the decision in #14807 was that no change to the cppflags was necessary? You're right, that addition was a mistake. The only change that needs to be made is to add the dependency on port:freetype. Once that's in place, the fox configure script will amend the include path itself properly.
-- Ticket URL: <http://trac.macports.org/ticket/17741#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17741: UPDATE: fox-1.6.34 -----------------------------------+---------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Keywords: | Port: fox -----------------------------------+---------------------------------------- Comment(by lyle@…): You know, let's hold off on this for the moment. I'd like to do a clean install of MacPorts and confirm that the dependencies are really correct. -- Ticket URL: <http://trac.macports.org/ticket/17741#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17741: UPDATE: fox-1.6.34 -----------------------------------+---------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Keywords: | Port: fox -----------------------------------+---------------------------------------- Comment(by lyle@…): OK, I think this is it. Adding a dependency on port:freetype is not enough, because the fox configure script attempts to use the pkg-config utility to determine how it should modify the CFLAGS (i.e. what to add to the compile-time include path). So we actually need dependencies on port:freetype and port:pkgconfig. I've updated the patch to reflect these changes. -- Ticket URL: <http://trac.macports.org/ticket/17741#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#17741: UPDATE: fox-1.6.34 ------------------------------------+--------------------------------------- Reporter: lyle@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.7.0 Resolution: fixed | Keywords: Port: fox | ------------------------------------+--------------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Ok, sounds good. I committed it in r44292 except that pkgconfig is a build dependency not a library dependency. -- Ticket URL: <http://trac.macports.org/ticket/17741#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts