[MacPorts] #47572: xfce4-settings @@ 4.6.5 fails to build due to a change in libnotify
#47572: xfce4-settings @@ 4.6.5 fails to build due to a change in libnotify -------------------------+-------------------------------- Reporter: wyatt8750@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: xfce4-settings -------------------------+-------------------------------- LibNotify's notify_notification_new() now takes fewer arguments than it used to, and the version of xfce4-settings in macports is still using the old argument count. Line 420 in accessibility is to blame, and it can be made to compile by doing something like this: {{{ --- old/xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c 2015-04-25 19:55:26.000000000 -0400 +++ xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c 2015-04-25 19:55:36.000000000 -0400 @@ -417,7 +417,7 @@ if (helper->notification == NULL) { /* create a new notification */ - helper->notification = notify_notification_new (summary, body, "keyboard", NULL); + helper->notification = notify_notification_new (summary, body, "keyboard"); /* close signal */ g_signal_connect (G_OBJECT (helper->notification), "closed", G_CALLBACK (xfce_accessibility_helper_notification_closed), helper); }}} I don't know if my paths in that patch are correct, but this did seem to fix my issue. If it matters, I am running OS X 10.6.8 (snow leopard) with xcode 4.2's SDK. The patch is also attached, as is the original build log. -- Ticket URL: <https://trac.macports.org/ticket/47572> MacPorts <https://www.macports.org/> Ports system for OS X
#47572: xfce4-settings @4.6.5 fails to build due to a change in libnotify -----------------------------+---------------------- Reporter: wyatt8750@… | Owner: afb@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: xfce4-settings | -----------------------------+---------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => afb@… * cc: afb@… (removed) Comment: Perhaps we should try updating the port to the current version (4.12) first. -- Ticket URL: <https://trac.macports.org/ticket/47572#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47572: xfce4-settings @4.6.5 fails to build due to a change in libnotify -----------------------------+---------------------- Reporter: wyatt8750@… | Owner: afb@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: xfce4-settings | -----------------------------+---------------------- Comment (by wyatt8750@…): Maybe updating would be a good move. -- Ticket URL: <https://trac.macports.org/ticket/47572#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#47572: xfce4-settings @4.6.5 fails to build due to a change in libnotify -----------------------------+---------------------- Reporter: wyatt8750@… | Owner: afb@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: haspatch Port: xfce4-settings | -----------------------------+---------------------- Changes (by afb@…): * status: new => closed * resolution: => fixed Comment: Fixed, r144133. -- Ticket URL: <https://trac.macports.org/ticket/47572#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts