[MacPorts] #15860: umit
#15860: umit --------------------------------+------------------------------------------- Reporter: luis.kop@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Keywords: | --------------------------------+------------------------------------------- Hi all. I'm developer of Umit Project and i'm here to request that you test and give suggestions to fix and add our Portfile to our servers, if is it possible. I hope your feedback. Thanks for all. -- Ticket URL: <http://trac.macports.org/ticket/15860> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by raimue@macports.org): patch-base.diff hardcodes the prefix `/opt/local` into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace. You already added a reinplace for ${prefix} in `post-destroot {}`, but I think it would be more appropriate to do this in `post-patch {}`. -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by luis.kop@gmail.com): Replying to [comment:2 raimue@macports.org]:
patch-base.diff hardcodes the prefix `/opt/local` into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.
You already added a reinplace for ${prefix} in `post-destroot {}`, but I think it would be more appropriate to do this in `post-patch {}`.
Hi. Thanks for the comment. About the patch-base it's true, it's hardcode. But how hack the file during the installation. Using sed? About replace post-destroot by post-patch it's not a good idea. It didn't work. Is it mandatory in post-patch? -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by raimue@macports.org): Use this in the patch file: {{{ CONFIG_DIR = "__PREFIX__/share/umit/config" ... }}} And use this post-patch: {{{ post-patch { reinplace "s|__PREFIX__|${prefix}|g" ${worksrcpath}/umitCore/BasePaths.py } }}} I don't think you need another reinplace in post-destroot. -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by luis.kop@gmail.com): yeah. It's true. You're right. I copy this from other Portfile and I didn't understand. Now I understand and I fix it. The files are commited. What do you think about that? Is it ok, now? :) -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: raimue@macports.org Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Changes (by raimue@macports.org): * owner: macports-tickets@lists.macosforge.org => raimue@macports.org * status: new => assigned -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15860: umit ---------------------------------+------------------------------------------ Reporter: luis.kop@gmail.com | Owner: raimue@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Requests Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: ---------------------------------+------------------------------------------ Changes (by raimue@macports.org): * status: assigned => closed * resolution: => fixed Comment: Committed in r38112. -- Ticket URL: <http://trac.macports.org/ticket/15860#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts